Mutable Release Tag (AST-151094)#1491
Open
cx-aniket-shinde wants to merge 5 commits intomainfrom
Open
Conversation
cx-aniket-shinde
requested review from
cx-anjali-deore,
cx-anurag-dalke and
cx-umesh-waghode
as code owners
cx-aniket-shinde
changed the title
cx-aniket-shinde
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
…re build completes - Set release.disable: true in both goreleaser configs so GoReleaser builds artifacts and uploads to S3/Docker without ever calling the GitHub Releases API (which previously created the immutable tag as a side effect of draft release creation) - Replace the draft publish step with an explicit push-tag + gh release create sequence: tag only hits GitHub after all artifacts are fully built and signed, making the entire build phase safely retryable under org-level immutable tag rules - Dev builds get --prerelease, prod builds get --latest via gh release create Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ploaded gh release create without --draft publishes the release immediately via the API before artifact uploads complete, leaving a window where users see an empty release. Using --draft ensures all .tar.gz, .zip, and checksums files are fully uploaded before gh release edit flips it to published. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The explicit git push step published the tag before any release or assets existed, creating a window where the tag was public with nothing attached. If gh release create then failed, the tag was permanently stranded. New sequence: - gh release create --draft --target <sha>: uploads all assets, tag not yet public (GitHub defers the ref until the draft is published) - gh release edit --draft=false: tag and release become public together Also adds: - set -euo pipefail + shopt -s failglob so an empty dist/ or any command failure exits loudly before touching GitHub - Cleanup step (if: failure()) that deletes a leftover draft so the next run is not blocked; --cleanup-tag is best-effort (|| true) since the org immutable-tag policy may prevent tag deletion, but the release deletion alone is sufficient to unblock a retry Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.