Fix AST-137779: Do not auto-load results on scan completion

Previously, two syncExec blocks fired when a scan completed: the first
auto-loaded results immediately (causing a 'no results' flash and
bypassing the notification), and the second showed the notification
popup whose 'Load Results' button would load a second time.

Merged into a single syncExec that: refreshes the scan list, marks the
new scan ID as latest in preferences, and shows the notification. Results
are now only loaded when the user explicitly clicks 'Load Results'. If the
notification is closed or ignored the current results remain visible and
the new scan ID is still available in the scan list as latest.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: cx-aniket-shinde

checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/actions/ActionStartScan.java

@@ -334,30 +334,19 @@ private Runnable pollingScan(String scanId) {
 					startScanAction.setEnabled(true);
 
 					if (scan.getStatus().toLowerCase(Locale.ROOT).equals(PluginConstants.CX_SCAN_COMPLETED_STATUS)) {
-						// Automatically update UI with new scan result
 						Display.getDefault().syncExec(new Runnable() {
+							AbstractNotificationPopup notification;
+
 							@Override
 							public void run() {
-								// Fetch the latest scan list for the branch
+								// Refresh the scan list and mark the new scan as latest —
+								// but do NOT auto-load results or change the current view.
 								List<Scan> scanList = DataProvider.getInstance().getScansForProject(branchesCombo.getCombo().getText());
-								// Set the new scan as latest by updating preferences
 								GlobalSettings.storeInPreferences("LATEST_SCAN_ID", scanId);
-								// Set the scan list in the combo viewer
-                                scansCombo.setInput(scanList);
-                                // Set the new scan as selected
-                                scansCombo.getCombo().setText(scanId);
-								// Post event to load results for the new scan
-								pluginEventBus.post(new PluginListenerDefinition(
-									PluginListenerType.LOAD_RESULTS_FOR_SCAN,
-									Collections.emptyList()));
-							}
-						});
-						// Show notification as before
-						Display.getDefault().syncExec(new Runnable() {
-							AbstractNotificationPopup notification;
+								scansCombo.setInput(scanList);
 
-							@Override
-							public void run() {
+								// Show notification. Results only load when the user explicitly
+								// clicks "Load Results"; closing/ignoring leaves the current view intact.
 								notification = new NotificationPopUpUI(Display.getCurrent(),
 										PluginConstants.CX_SCAN_FINISHED_TITLE,
 										PluginConstants.CX_SCAN_FINISHED_DESCRIPTION, null,
@@ -366,12 +355,11 @@ PluginConstants.CX_LOAD_SCAN_RESULTS, new SelectionAdapter() {
 											public void widgetSelected(SelectionEvent e) {
 												scansCombo.getCombo().setText(scanId);
 												pluginEventBus.post(new PluginListenerDefinition(
-													PluginListenerType.LOAD_RESULTS_FOR_SCAN,
-													Collections.emptyList()));
+														PluginListenerType.LOAD_RESULTS_FOR_SCAN,
+														Collections.emptyList()));
 												notification.close();
 											}
 										});
-
 								notification.setDelayClose(100000000);
 								notification.open();
 							}