Fix: Truncate long custom state names in filter menu (AST-137779) (#246)

* Fix AST-137779: Truncate long custom state names in filter menu and triage combo

Custom states with very long names caused the state filter dropdown menu
to expand across the entire screen. Fix truncates display text to 50 chars
(with trailing "...") in both the state filter MenuItem and the triage
state ComboViewer LabelProvider. The full state name is still used
internally for filtering and triage submission.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Fix AST-137779: Guard against null getResults() in cxProjectMatchesWorkspaceProject

Results.getResults() can return null when no results have been loaded yet
(e.g. fresh IDE session before any scan is imported). The prior check only
guarded against a null Results object, causing an NPE on the first click
of the Start Scan button and preventing scans from running.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: cx-aniket-shinde

checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/CheckmarxView.java

@@ -627,6 +627,13 @@ private void createResultViewPanel(Composite resultsComposite) {
 		combo_1.setLayoutData(gd_combo_1);
 
 		triageStateComboViewer = new ComboViewer(triageView, SWT.READ_ONLY);
+		triageStateComboViewer.setLabelProvider(new LabelProvider() {
+			@Override
+			public String getText(Object element) {
+				String s = element instanceof String ? (String) element : super.getText(element);
+				return s.length() > 50 ? s.substring(0, 47) + "..." : s;
+			}
+		});
 		Combo combo_2 = triageStateComboViewer.getCombo();
 		combo_2.setEnabled(true);
 		combo_2.setData(PluginConstants.DATA_ID_KEY, PluginConstants.TRIAGE_STATE_COMBO_ID);

checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/actions/ActionFilterStatePreference.java

@@ -89,7 +89,7 @@ public Menu getMenu(final Control parent) {
 
 		for (String customState : customStates) {
 			MenuItem item = new MenuItem(menu, SWT.CHECK);
-			item.setText(customState);
+			item.setText(truncate(customState));
 			item.setSelection(FilterState.isCustomStateSelected(customState));
 			item.addSelectionListener(new SelectionAdapter() {
 				@Override
@@ -127,4 +127,8 @@ public void widgetSelected(SelectionEvent e) {
 	public Menu getMenu(final Menu parent) {
 		return null;
 	}
+
+	private static String truncate(String text) {
+		return text.length() > 50 ? text.substring(0, 47) + "..." : text;
+	}
 }

checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/actions/ActionStartScan.java

@@ -220,7 +220,7 @@ private String getCurrentGitBranch() {
 	 */
 	private boolean cxProjectMatchesWorkspaceProject() {
 		Results results = DataProvider.getInstance().getCurrentResults();
-		boolean noResultsInScan = results == null || results.getResults().isEmpty();
+		boolean noResultsInScan = results == null || results.getResults() == null || results.getResults().isEmpty();
 		boolean noFilesInWorkspace = ResourcesPlugin.getWorkspace().getRoot().getProjects().length == 0;
 
 		if (noResultsInScan || noFilesInWorkspace) {