Fix: Results are not loaded on re-install plugin(AST-107449)#1499
Open
cx-sumit-morchhale wants to merge 1 commit into
Open
Fix: Results are not loaded on re-install plugin(AST-107449)#1499cx-sumit-morchhale wants to merge 1 commit into
cx-sumit-morchhale wants to merge 1 commit into
Conversation
…oading (AST-107449) - Change readResultsFromFile() to return undefined when file doesn't exist instead of returning empty array, creating semantic distinction between "not yet loaded" (undefined) vs "loaded with 0 items" ([]) - Update loadedResults type annotation to CxResult[] | undefined to match actual usage - Fix scanId retrieval to use .id instead of .name for correct UUID This prevents the tree from showing "No vulnerability" prematurely while results are still being fetched. The message now only shows after results are actually loaded and are empty. Tested and verified: - ✅ No regressions in triage operations - ✅ No regressions in filtering/grouping - ✅ Risk management view safely handles undefined - ✅ All existing functionality preserved - ✅ Both Checkmarx and Project Ignite plugins safe Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cx-sumit-morchhale
changed the title
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
cx-rahul-pidde
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readResultsFromFile()to returnundefinedwhen file doesn't exist (semantic distinction: undefined = not loaded, [] = loaded but empty)loadedResultstype annotation toCxResult[] | undefinedto match actual usage.idinstead of.namefor correct UUIDTesting
Type Safety
🤖 Generated with Claude Code