Skip to content

Fix: Results are not loaded on re-install plugin(AST-107449) #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-sumit-morchhale wants to merge 1 commit into
base: other/integration-branch
Choose a base branch
from
+5 −5
Open

Fix: Results are not loaded on re-install plugin(AST-107449) #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,10 @@ export async function getResultsJson() {
export function readResultsFromFile(
resultJsonPath: string,
scan: string
): Promise<CxResult[]> {
): Promise<CxResult[] | undefined> {
return new Promise((resolve, reject) => {
if (!fs.existsSync(resultJsonPath) || !scan) {
resolve([]);
resolve(undefined);
return;
}

Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/views/resultsView/astResultsProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { validateConfigurationAndLicense } from "../../utils/common/configValida

export class AstResultsProvider extends ResultsProvider {
public process;
public loadedResults: CxResult[];
public loadedResults: CxResult[] | undefined;
private scan: Item | undefined;
private riskManagementView: riskManagementView;

Expand Down Expand Up @@ -87,8 +87,8 @@ export class AstResultsProvider extends ResultsProvider {
this.loadedResults = undefined;
const scanIDItem = getFromState(this.context, constants.scanIdKey);
let scanId = undefined;
if (scanIDItem && scanIDItem.name) {
scanId = getFromState(this.context, constants.scanIdKey).name;
if (scanIDItem && scanIDItem.id) {
scanId = getFromState(this.context, constants.scanIdKey).id;
}
if (scanId) {
await getResultsWithProgress(this.logs, scanId);
Expand Down
Loading