Skip to content

Commit daba41a

Browse files
committed
fix(vscode): demote OMD auth to warning
v0.4.2 OMD auth-required surfaced as critical in the cockpit and Issues view, which is too loud — `tty_tickets` simply asks for a sudo refresh and the rest of the IDE keeps working. Downgrade both the `omd:auth` issue severity and the OMD domain rollup to warning. The badge ("sudo required") and the Authenticate action are unchanged. AI-Generated: true Change-Id: Ie003d7dea27a41e662347a33c1e8b4eb8123235d
1 parent a6651a1 commit daba41a

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

.ide/vscode/changelog/v0.4.2.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
## v0.4.2
22

3+
- **fix**: demote OMD auth to warning
34
- **fix**: cockpit stale build detection

.ide/vscode/src/sidebar/overview/domainSummary.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,14 +483,14 @@ export function enumerateIssues(state: StateCache): Issue[] {
483483
})
484484
}
485485

486-
// OMD: auth required → critical; any stopped site (without needing auth) → warning.
486+
// OMD: auth required or any stopped site (without needing auth) → warning.
487487
if (omdSites && omdSites.length > 0) {
488488
const needsAuth = omdSites.some((s) => s.status.overall === -1)
489489
if (needsAuth) {
490490
out.push({
491491
id: 'omd:auth',
492492
domain: 'omd',
493-
severity: 'critical',
493+
severity: 'warning',
494494
label: 'OMD authentication',
495495
description: 'sudo required · Authenticate',
496496
tooltip:
@@ -605,7 +605,7 @@ export function getDomainSummary(state: StateCache): DomainSummary {
605605
let omdSeverity: Severity = 'ok'
606606
let omdBadge: string
607607
if (auth) {
608-
omdSeverity = 'critical'
608+
omdSeverity = 'warning'
609609
omdBadge = 'sudo required'
610610
} else if (stoppedIssue) {
611611
omdSeverity = 'warning'

.ide/vscode/tests/sidebar/overview/domainSummary.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ describe('enumerateIssues', () => {
276276
expect(issues[0].id).toBe('pylance:over-threshold')
277277
})
278278

279-
it('flags OMD auth as critical when any site status is unknown', () => {
279+
it('flags OMD auth as warning when any site status is unknown', () => {
280280
const issues = enumerateIssues(
281281
emptyState({
282282
omdSites: [
@@ -293,7 +293,7 @@ describe('enumerateIssues', () => {
293293
})
294294
)
295295
expect(issues[0].id).toBe('omd:auth')
296-
expect(issues[0].severity).toBe('critical')
296+
expect(issues[0].severity).toBe('warning')
297297
})
298298

299299
it('flags OMD stopped sites as warning when no auth needed', () => {

0 commit comments

Comments
 (0)