fix: preserve model group labels#14806
Open
404-Page-Found wants to merge 2 commits into
Open
Conversation
Signed-off-by: 404-Page-Found <Lucas20220605@gmail.com>
6 tasks
Contributor
Author
|
Note This comment was translated by Claude. Adding the latest feedback on issue #14362: The user who reported the bug confirmed that this issue still reproduces in version 1.9.4, and it not only affects the model group display but also further affects model invocation, making it a functional regression issue. Original Content补充一下 issue #14362 的最新反馈:提 bug 的用户确认在 1.9.4 版本里这个问题仍然复现,而且它不仅影响模型分组显示,还会进一步影响模型调用,属于功能性回归问题。 |
5 tasks
DeJeune
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Model list group headers could show raw provider-style slugs, and a generic formatter could also mangle canonical family ids like
gpt-5andgpt-image.After this PR:
Model list group labels are normalized conservatively: known provider slugs are rendered with friendly names, while canonical family ids remain unchanged.
Fixes #14362
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
gpt-5.Links to places where the discussion took place:
Breaking changes
None.
Special notes for your reviewer
Verified with
pnpm exec vitest run src/renderer/src/utils/__tests__/model.test.ts.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note