feat(app-shell): open chat by default#14943
Open
kangfenmao wants to merge 2 commits into
Open
Conversation
Signed-off-by: kangfenmao <kangfenmao@qq.com>
Member
|
Note This comment was translated by Claude.
Specifically, it's best to discuss and confirm with the product team. Original Content
具体的,最好是和产品一起讨论确认。 |
Collaborator
Author
|
Note This comment was translated by Claude.
This PR is only used to remove the default Tab. The PR has a single responsibility, and tab state persistence will be done in follow-up work. Original Content这个 PR 仅用来移除默认的 Tab,PR 单一职责,tabs 的状态保持会放在后续来做 |
Collaborator
|
Note This comment was translated by Claude. Conflicts need to be resolved. Original Content需要解决冲突 |
…-default Signed-off-by: kangfenmao <kangfenmao@qq.com> # Conflicts: # src/renderer/src/components/layout/AppShellTabBar.tsx # src/renderer/src/routeTree.gen.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR: Cherry Studio opened the main window with the Launchpad/Home tab selected and showed a dedicated Home icon plus separator in the tab bar.
After this PR: Cherry Studio opens directly to the chat tab, removes the dedicated Home tab-bar icon and separator, keeps sidebar navigation reusing the active main tab, and moves Launchpad access to the
+tab action via/app/launchpad.Fixes # N/A
Why we need it and why it was done in this way
The following tradeoffs were made: the old
/and/homeroutes are removed instead of kept as compatibility aliases, matching the requested v2 navigation behavior.The following alternatives were considered: keeping
/homeas a redirect or making+create another chat tab, but those did not match the desired startup and Launchpad behavior.Links to places where the discussion took place: N/A
Breaking changes
No external API breaking changes. The user-visible startup route changes from Home/Launchpad to Chat, and Launchpad now lives at
/app/launchpad.Special notes for your reviewer
pnpm build:checkpasses. Existing legacy CSS variable warnings are still emitted by lint and are unrelated to this PR.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note