refactor(file-processing-settings): file-processing-settings#14964
Closed
eeee0717 wants to merge 11 commits into
Closed
refactor(file-processing-settings): file-processing-settings#14964eeee0717 wants to merge 11 commits into
eeee0717 wants to merge 11 commits into
Conversation
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
All service methods accepting a Drizzle transaction now follow: - tx is the first parameter - method name ends with Tx Renamed: - pinService.purgeForEntity / purgeForEntities -> *Tx - tagService.purgeForEntity / purgeForEntities -> *Tx - TagService#assertTagsExist (private) -> assertTagsExistTx - PromptService#assertPromptsExist (private) -> assertPromptsExistTx - AssistantService#syncRelations (private) -> syncRelationsTx - AgentService#syncSettingsToSessions (private) -> syncSettingsToSessionsTx The convention is documented in docs/references/data/data-api-in-main.md under the new "Transaction Method Naming" section. Behavior is unchanged.
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
#14940) Co-authored-by: SuYao <sy20010504@gmail.com> Co-authored-by: fullex <106392080+0xfullex@users.noreply.github.com>
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
Signed-off-by: eeee0717 <chentao020717Work@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
File processing settings were split across the legacy document-processing settings UI. Processor configuration was also harder to reason about because renderer and main-process code did not share the same layered preset model.
After this PR:
Fixes #
N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
N/A
Breaking changes
None.
Special notes for your reviewer
Out of scope / intentionally not addressed in this PR:
useAvailableFileProcessorsnow exposes a status internally, but this PR does not add a visible error state. On lookup failure, the page logs a warning, hides OV OCR, and leaves the remaining processors visible.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note