fix: Restore to project directory after using nodewhisper#239
Merged
ChetanXpro merged 1 commit intoChetanXpro:mainfrom Apr 11, 2026
Merged
fix: Restore to project directory after using nodewhisper#239ChetanXpro merged 1 commit intoChetanXpro:mainfrom
ChetanXpro merged 1 commit intoChetanXpro:mainfrom
Conversation
|
Could you apply the same finally-statement in src/autoDownloadModel.ts? It also only resets in the catch-block. Edit: And in src/downloadModel.ts which doesn't seem to have any cleanup logic at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor oversight. When using
nodewhisper(), it changes the current working directory to./cpp/whisper.cppinstead of the project directory. This could cause problems when using other processes that rely on the current working directory.This just restores the current directory to the project directory after all functions are done. Funny enough, this was already handled when an error occurred with
handleError().