fix: use platform-appropriate script path in downloader check on Windows#243
Merged
ChetanXpro merged 1 commit intoChetanXpro:mainfrom Apr 11, 2026
Merged
Conversation
Replace faulty `if (!shell.which('./download-ggml-model.sh')) {
throw '[Nodejs-whisper] Error: Downloader not found.\n'
}` downloader check script on Windows.
Fixes ChetanXpro#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242
How to test
On Windows
npm installnpx nodejs-whisper downloadbefore this fix (checkoutmain)[Nodejs-whisper] Error: Downloader not found.npx nodejs-whisper downloadagainSimulating the bug on any platform
The
which()check can be tested in isolation:Run this inside cpp/whisper.cpp/models/ where the scripts live.
Unit-level check (any platform)
You can also force the Windows branch by temporarily hardcoding process.platform === 'win32' to true in the fixed code and confirming which() resolves download-ggml-model.cmd correctly.
Note
I later hit a
libgomp-1.dllcrash you hit as a downstream consequence of this bug: because the download/build never ran, an old MinGW-linked binary was sitting there from a prior partial build attempt. The real first failure was this which() check. Looking to fix this bug first before filing the libgomp one as a separate issue + PR after this one merges.