Add comprehensive tests for kube reconciler functions#330
Merged
Conversation
Cover all reconciler functions (Service, Deployment, StatefulSet, PVC, ConfigMap, Ingress) with envtest integration tests for create, update, and delete scenarios, plus pure unit tests for filterStaleContainers and filterStaleContainerFields helpers. Made-with: Cursor
Starttoaster
enabled auto-merge (squash)
March 17, 2026 19:51
cmmarslender
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReconcileService,ReconcileDeployment,ReconcileStatefulset,ReconcilePersistentVolumeClaim,ReconcileConfigMap, andReconcileIngressfilterStaleContainersandfilterStaleContainerFieldshelper functionsMade with Cursor
Note
Low Risk
Test-only changes that expand coverage of Kubernetes reconciler behavior; production reconciliation code is unchanged, but failures could affect CI reliability due to additional envtest scenarios.
Overview
Adds a large set of new Ginkgo specs in
reconcilers_test.go, expanding from basicserverSideApplycoverage to envtest integration tests forReconcileConfigMap,ReconcileService,ReconcilePersistentVolumeClaim,ReconcileIngress,ReconcileDeployment, andReconcileStatefulsetacross create/update and disabled delete/no-op paths.Also introduces pure unit tests for
filterStaleContainersandfilterStaleContainerFields, including cases for selector immutability-triggered Deployment/StatefulSet recreation, stale container removal, and clearing stale optional container fields.Written by Cursor Bugbot for commit 33fb01e. This will update automatically on new commits. Configure here.