Propagate module dialect before compilation#515
Draft
aqk wants to merge 1 commit into
Draft
Conversation
Ensure module-style sources use the detected module dialect before frontend, cache, and module compilation so module-only CSE fixes are consistently enabled.
aqk
marked this pull request as draft
July 7, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Medium Risk
Touches core compile entry and optimizer dialect flags; wrong detection or dialect propagation could change codegen or cache behavior for module inputs.
Overview
compile_pre_formsnow runsdetect_chialisp_moduleon raw pre-forms and updatesoptswith the moduledialectandstdenv(fromdialect.strict) beforefrontend, so module files get the right language settings even when compilation starts with default options (affects parsing, disk cache keys, and the module path).In
compile_module,cse_dominanceis always turned on for modules instead of only whenstepping < 26, so module CSE dominance semantics apply consistently regardless of stepping on the incoming dialect.Reviewed by Cursor Bugbot for commit 25beafc. Bugbot is set up for automated code reviews on this repo. Configure here.