Reduce cross-platform build warning noise (#315)

* Reduce CI/build warning noise and harden cross-platform behavior.

Rebase warning-cleanup work onto current main, keep vdf_client session parser refactor from #313, and apply targeted warning/robustness fixes across CI workflows, CMake/build scripts, and core/runtime code paths.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Restore full 2weso CI durations and tighten Python/Cargo target plumbing.

Remove temporary shortened 2weso test overrides in vdf-client-hw CI and align build scripts with modern CMake/Cargo target variables to eliminate unused PYTHON_EXECUTABLE warnings and keep MSVC-only CRT overrides scoped correctly.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Consolidate checked integer casts across C/C++ and Python bindings.

Replace ad-hoc narrowing checks and release-elided asserts with a shared checked_cast helper to keep overflow handling consistent across wrapper and test paths.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix unsigned-to-signed checked_cast overflow guard and add regression coverage.

The unsigned-to-signed conversion path now checks against the signed destination max, preventing silent wraparound for values above INT32_MAX, and adds a GoogleTest regression to lock this behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix signed-widening behavior in checked_cast and add regression coverage.

Avoid truncated bounds checks for same-signed widening casts and add positive/negative int32-to-int64 tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use checked_cast for primetest and verifier discriminant conversions.

Replace manual narrowing checks/casts with checked_cast to keep overflow handling consistent and centralized.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use 64-bit recursion and proof lengths in verifier APIs.

Align the Python and C bindings with the native verifier interface by accepting full-size proof blob lengths and recursion depth instead of narrowing to int32, removing wrapper-level truncation guards.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use logical OR for uint128 comparison operators.

Switch boolean composition in <= and >= from bitwise OR to logical OR for clearer intent and short-circuit behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Update verifier proof-length tests and known-proof fixture.

Switch verifier and stress tests to pass proof blob lengths as size_t without narrowing casts, and refresh verifier_test's fixed proof vector to a current-format fixture so the known-proof assertion remains meaningful with the widened verifier API.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Mirror production verifier path in known-proof test.

Update verifier_test to construct and reuse the discriminant before calling CheckProofOfTimeNWesolowski directly, so the test reflects production verifier usage while keeping the current-format known-proof fixture.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Pass witness_type directly to uint64 depth API.

Remove the obsolete int32_t intermediate cast in stress_test so the call matches the updated verifier depth parameter type.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Inline env_flag use in prover_test fast-mode check.

Remove the redundant env_truthy wrapper and call env_flag directly to keep the test setup path simpler without changing behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Revert "Use logical OR for uint128 comparison operators."

This reverts commit 8db997d.

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: hoffmang9

.github/workflows/build.yml

@@ -106,16 +106,39 @@ jobs:
       run: |
         pip install pipx
 
-    - name: Build and test
+    - name: Build and test (Linux)
+      if: matrix.os.matrix == 'ubuntu'
       env:
         CIBW_BUILD: ${{ matrix.python.cibw-build }}
         CIBW_MANYLINUX_AARCH64_IMAGE: ${{ matrix.python.manylinux }}
         CIBW_MANYLINUX_X86_64_IMAGE: ${{ matrix.python.manylinux }}
+        CIBW_PRERELEASE_PYTHONS: True
+      run:
+        pipx run --spec=${{ matrix.python.cibuildwheel }} cibuildwheel --output-dir dist 2>&1
+
+    - name: Build and test (macOS)
+      if: matrix.os.matrix == 'macos'
+      env:
+        CIBW_BUILD: ${{ matrix.python.cibw-build }}
         CIBW_ARCHS_MACOS: ${{ matrix.os.cibw-archs-macos[matrix.arch.matrix] }}
         CIBW_PRERELEASE_PYTHONS: True
       run:
         pipx run --spec=${{ matrix.python.cibuildwheel }} cibuildwheel --output-dir dist 2>&1
 
+    - name: Build and test (Windows)
+      if: matrix.os.matrix == 'windows'
+      env:
+        # pipx warns when its home path contains spaces (common on Windows runners).
+        # Use a fixed no-space location to avoid pipx path compatibility issues.
+        PIPX_HOME: 'C:\pipx'
+        PIPX_BIN_DIR: 'C:\pipx\bin'
+        # setuptools emits this benign warning in some Windows wheel builds.
+        PYTHONWARNINGS: 'ignore:.*Py_DEBUG.*ABI tag may be incorrect:RuntimeWarning'
+        CIBW_BUILD: ${{ matrix.python.cibw-build }}
+        CIBW_PRERELEASE_PYTHONS: True
+      run:
+        pipx run --spec=${{ matrix.python.cibuildwheel }} cibuildwheel --output-dir dist 2>&1
+
     - name: Upload artifacts
       uses: actions/upload-artifact@v5
       with:

rust_bindings/build.rs

@@ -23,7 +23,8 @@ fn main() {
             .to_path_buf();
     }
 
-    let dst = Config::new(src_dir.as_path())
+    let mut config = Config::new(src_dir.as_path());
+    config
         .build_target("chiavdfc_static")
         .define("BUILD_CHIAVDFC", "ON")
         .env("BUILD_VDF_CLIENT", "N")
@@ -35,8 +36,20 @@ fn main() {
             } else {
                 "OFF"
             },
-        )
-        .build();
+        );
+
+    let target_os = std::env::var("CARGO_CFG_TARGET_OS").unwrap_or_default();
+    let target_env = std::env::var("CARGO_CFG_TARGET_ENV").unwrap_or_default();
+
+    if target_os == "windows" && target_env == "msvc" {
+        // Rust MSVC links against msvcrt in both debug/release test builds.
+        // Keep CMake-produced static libs on the same CRT to avoid *_dbg unresolved symbols.
+        config
+            .define("CMAKE_POLICY_DEFAULT_CMP0091", "NEW")
+            .define("CMAKE_MSVC_RUNTIME_LIBRARY", "MultiThreadedDLL");
+    }
+
+    let dst = config.build();
 
     println!("cargo:rustc-link-lib=static=chiavdfc");
 
@@ -49,7 +62,7 @@ fn main() {
             .unwrap()
     );
 
-    if cfg!(target_os = "windows") {
+    if target_os == "windows" {
         println!("cargo:rustc-link-lib=static=mpir");
         println!(
             "cargo:rustc-link-search=native={}",
@@ -60,7 +73,7 @@ fn main() {
                 .to_str()
                 .unwrap()
         );
-    } else if cfg!(target_os = "macos") {
+    } else if target_os == "macos" {
         println!("cargo:rustc-link-lib=static=gmp");
         let homebrew_path = if fs::metadata("/opt/homebrew").is_ok() {
             "/opt/homebrew/lib"

setup.py

@@ -1,21 +1,14 @@
 import os
 import platform
-import shutil
 import subprocess
 import sys
 from pathlib import Path
 
 from setuptools import Command, Extension, setup
 from setuptools.command.build import build
 from setuptools.command.build_ext import build_ext
-from setuptools.command.install import install
 
 BUILD_HOOKS = []
-INSTALL_HOOKS = []
-
-
-def add_install_hook(hook):
-    INSTALL_HOOKS.append(hook)
 
 
 def add_build_hook(hook):
@@ -28,29 +21,20 @@ def __init__(self, dist):
         Command.__init__(self, dist)
 
     def initialize_options(self, *args):
-        self.install_dir = None
         self.build_dir = None
 
     def finalize_options(self):
         self.set_undefined_options("build", ("build_scripts", "build_dir"))
-        self.set_undefined_options(
-            "install",
-            ("install_platlib", "install_dir"),
-        )
 
     def run(self):
         for _ in self.hooks:
-            _(install_dir=self.install_dir, build_dir=self.build_dir)
+            _(build_dir=self.build_dir)
 
 
 class build_hook(HookCommand):
     hooks = BUILD_HOOKS
 
 
-class install_hook(HookCommand):
-    hooks = INSTALL_HOOKS
-
-
 ############################################
 
 
@@ -60,17 +44,6 @@ def __init__(self, name, sourcedir=""):
         self.sourcedir = os.path.abspath(sourcedir)
 
 
-def copy_vdf_client(build_dir, install_dir):
-    shutil.copy("src/vdf_client", install_dir)
-    shutil.copy("src/prover_test", install_dir)
-    shutil.copy("src/1weso_test", install_dir)
-    shutil.copy("src/2weso_test", install_dir)
-
-
-def copy_vdf_bench(build_dir, install_dir):
-    shutil.copy("src/vdf_bench", install_dir)
-
-
 def invoke_make(**kwargs):
     subprocess.check_output("make -C src -f Makefile.vdf-client", shell=True)
 
@@ -82,12 +55,6 @@ def invoke_make(**kwargs):
 if BUILD_VDF_CLIENT or BUILD_VDF_BENCH:
     add_build_hook(invoke_make)
 
-if BUILD_VDF_CLIENT:
-    add_install_hook(copy_vdf_client)
-
-if BUILD_VDF_BENCH:
-    add_install_hook(copy_vdf_bench)
-
 
 class CMakeBuild(build_ext):
     def run(self):
@@ -107,7 +74,7 @@ def build_extension(self, ext):
         extdir = os.path.abspath(os.path.dirname(self.get_ext_fullpath(ext.name)))
         cmake_args = [
             "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=" + str(extdir),
-            "-DPYTHON_EXECUTABLE=" + sys.executable,
+            "-DPython_EXECUTABLE=" + sys.executable,
         ]
 
         cfg = "Debug" if self.debug else "Release"
@@ -133,7 +100,6 @@ def build_extension(self, ext):
 
 
 build.sub_commands.append(("build_hook", lambda x: True))  # type: ignore
-install.sub_commands.append(("install_hook", lambda x: True))
 
 # Wheel metadata generation on Windows can run with a non-UTF8 default encoding.
 # Read `README.md` explicitly as UTF-8 so `long_description` is robust across runners.
@@ -151,8 +117,6 @@ def build_extension(self, ext):
     long_description_content_type="text/markdown",
     url="https://github.com/Chia-Network/chiavdf",
     ext_modules=[CMakeExtension("chiavdf", "src")],
-    cmdclass=dict(
-        build_ext=CMakeBuild, install_hook=install_hook, build_hook=build_hook
-    ),
+    cmdclass=dict(build_ext=CMakeBuild, build_hook=build_hook),
     zip_safe=False,
 )

src/1weso_test.cpp

@@ -36,7 +36,7 @@ int main(int argc, char const* argv[]) try
     int d_bits = 1024;
     integer D = CreateDiscriminant(challenge_hash, d_bits);
 
-    if (getenv( "warn_on_corruption_in_production" )!=nullptr) {
+    if (env_flag("warn_on_corruption_in_production")) {
         warn_on_corruption_in_production=true;
     }
     set_rounding_mode();

src/2weso_test.cpp

@@ -44,7 +44,7 @@ int main(int argc, char const* argv[]) try
     std::vector<uint8_t> challenge_hash({0, 0, 1, 2, 3, 3, 4, 4});
     integer D = CreateDiscriminant(challenge_hash, 1024);
 
-    if (getenv( "warn_on_corruption_in_production" )!=nullptr) {
+    if (env_flag("warn_on_corruption_in_production")) {
         warn_on_corruption_in_production=true;
     }
     set_rounding_mode();

src/CMakeLists.txt

@@ -1,4 +1,4 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 3.14 FATAL_ERROR)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.18 FATAL_ERROR)
 option(BUILD_CHIAVDFC "Build the chiavdfc shared library" OFF)
 option(BUILD_PYTHON "Build the python bindings for chiavdf" ON)
 option(BUILD_VDF_CLIENT "Build the vdf_client binary" OFF)
@@ -8,6 +8,7 @@ option(BUILD_HW_TOOLS "Build hardware timelord tools" OFF)
 option(ENABLE_GNU_ASM "Enable GNU-style asm pipeline on x86/x64" ON)
 option(GENERATE_ASM_TRACKING_DATA "Emit asm tracking instrumentation data from compile_asm" OFF)
 option(HARDENING "Enable hardening" OFF)
+option(REQUIRE_MPIRXX "Require mpirxx/gmpxx C++ wrapper library on Windows" OFF)
 
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
@@ -44,6 +45,15 @@ set(CMAKE_MODULE_PATH
 
 if(MSVC)
   add_compile_options(/EHsc)
+  if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+    # Keep Windows clang-cl output focused on actionable issues.
+    # Keep this list minimal and avoid broad suppressions globally.
+    add_compile_options(
+      "/clang:-Qunused-arguments"
+      "/clang:-Wno-unused-command-line-argument"
+      "/clang:-Wno-unused-private-field"
+    )
+  endif()
   if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     # MSVC does not provide the GNU intrinsics headers used by compile_asm.
     set(ENABLE_GNU_ASM OFF CACHE BOOL "Enable GNU-style asm pipeline on x86/x64" FORCE)
@@ -60,7 +70,7 @@ if(APPLE)
 endif()
 
 if(WIN32)
-  add_compile_definitions(CHIA_WINDOWS NOMINMAX WIN32_LEAN_AND_MEAN)
+  add_compile_definitions(CHIA_WINDOWS NOMINMAX WIN32_LEAN_AND_MEAN _WIN32_WINNT=0x0601)
   set(MPIR_LIBRARY_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../mpir_gc_x64")
   set(MPIR_INCLUDE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../mpir_gc_x64")
   include_directories(
@@ -87,7 +97,11 @@ if(WIN32)
     set(GMPXX_LIBRARIES ${MPIRXX_LIBRARY})
     link_libraries(${MPIRXX_LIBRARY})
   else()
-    message(WARNING "MPIRXX library not found; gmpxx iostream operators may be missing")
+    set(GMPXX_LIBRARIES "")
+    if(REQUIRE_MPIRXX)
+      message(FATAL_ERROR "MPIRXX library not found but REQUIRE_MPIRXX=ON")
+    endif()
+    message(STATUS "MPIRXX library not found; continuing without gmpxx iostream operators")
   endif()
 
   list(APPEND CMAKE_PREFIX_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../mpir_gc_x64")
@@ -195,12 +209,33 @@ if(ENABLE_GNU_ASM AND (CMAKE_SYSTEM_PROCESSOR MATCHES "^(x86_64|AMD64|i[3-6]86)$
 endif()
 
 if(BUILD_PYTHON)
-  FetchContent_Declare(
-    pybind11-src
-    GIT_REPOSITORY https://github.com/pybind/pybind11.git
-    GIT_TAG        v2.13.6
-  )
-  FetchContent_MakeAvailable(pybind11-src)
+  # Prefer the pybind11 package from the active Python build environment.
+  # This avoids unnecessary FetchContent downloads and upstream CMake warning noise.
+  set(PYBIND11_FINDPYTHON ON)
+  find_package(Python REQUIRED COMPONENTS Interpreter Development.Module)
+
+  if(DEFINED Python_EXECUTABLE)
+    execute_process(
+      COMMAND "${Python_EXECUTABLE}" -m pybind11 --cmakedir
+      OUTPUT_VARIABLE PYBIND11_CMAKE_DIR
+      OUTPUT_STRIP_TRAILING_WHITESPACE
+      ERROR_QUIET
+      RESULT_VARIABLE PYBIND11_CMAKEDIR_RESULT
+    )
+    if(PYBIND11_CMAKEDIR_RESULT EQUAL 0 AND EXISTS "${PYBIND11_CMAKE_DIR}")
+      list(PREPEND CMAKE_PREFIX_PATH "${PYBIND11_CMAKE_DIR}")
+    endif()
+  endif()
+
+  find_package(pybind11 CONFIG QUIET)
+  if(NOT pybind11_FOUND)
+    FetchContent_Declare(
+      pybind11-src
+      GIT_REPOSITORY https://github.com/pybind/pybind11.git
+      GIT_TAG        v2.13.6
+    )
+    FetchContent_MakeAvailable(pybind11-src)
+  endif()
 
   pybind11_add_module(chiavdf
     ${CMAKE_CURRENT_SOURCE_DIR}/python_bindings/fastvdf.cpp
@@ -255,6 +290,11 @@ function(vdf_add_windows_clang_opts target_name)
         "$<$<COMPILE_LANGUAGE:C,CXX>:/O2>"
         "$<$<COMPILE_LANGUAGE:C,CXX>:/fp:fast>"
         "$<$<COMPILE_LANGUAGE:C,CXX>:/clang:-fno-math-errno>"
+        "$<$<COMPILE_LANGUAGE:C,CXX>:/clang:-Wno-unused-command-line-argument>"
+        # Finite-math mode can trigger this in transitive/system headers on clang-cl.
+        # Keep this suppression target-scoped to fast-math targets only.
+        "$<$<COMPILE_LANGUAGE:C,CXX>:/clang:-Wno-nan-infinity-disabled>"
+        "$<$<COMPILE_LANGUAGE:CXX>:/clang:-Wno-deprecated-literal-operator>"
       )
     else()
       target_compile_options(
@@ -341,6 +381,13 @@ if(BUILD_VDF_TESTS)
   vdf_add_windows_clang_opts(vdf_client_session_test)
   gtest_discover_tests(vdf_client_session_test TEST_PREFIX "regression.")
 
+  add_executable(checked_cast_test
+    ${CMAKE_CURRENT_SOURCE_DIR}/checked_cast_test.cpp
+  )
+  target_link_libraries(checked_cast_test PRIVATE GTest::gtest_main Threads::Threads)
+  vdf_add_windows_clang_opts(checked_cast_test)
+  gtest_discover_tests(checked_cast_test TEST_PREFIX "regression.")
+
 endif()
 
 if(BUILD_HW_TOOLS)
@@ -392,6 +439,7 @@ if(BUILD_HW_TOOLS)
   target_compile_definitions(hw_test PRIVATE ${VDF_COMMON_DEFINITIONS})
   target_include_directories(hw_test PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/hw ${CMAKE_CURRENT_SOURCE_DIR}/hw/libft4222)
   target_link_libraries(hw_test PRIVATE ${GMP_LIBRARIES} ${GMPXX_LIBRARIES} Threads::Threads ${HW_LIBS})
+  vdf_add_windows_clang_opts(hw_test)
   if(APPLE)
     target_link_options(hw_test PRIVATE "-Wl,-rpath,@executable_path/hw/libft4222")
   endif()
@@ -404,6 +452,7 @@ if(BUILD_HW_TOOLS)
   target_compile_definitions(hw_vdf_client PRIVATE ${VDF_COMMON_DEFINITIONS})
   target_include_directories(hw_vdf_client PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/hw ${CMAKE_CURRENT_SOURCE_DIR}/hw/libft4222)
   target_link_libraries(hw_vdf_client PRIVATE ${GMP_LIBRARIES} ${GMPXX_LIBRARIES} Threads::Threads ${HW_LIBS} ${HW_SOCKET_LIBS})
+  vdf_add_windows_clang_opts(hw_vdf_client)
   if(APPLE)
     target_link_options(hw_vdf_client PRIVATE "-Wl,-rpath,@executable_path/hw/libft4222")
   endif()
@@ -415,6 +464,7 @@ if(BUILD_HW_TOOLS)
   target_compile_definitions(emu_hw_test PRIVATE ${VDF_COMMON_DEFINITIONS})
   target_include_directories(emu_hw_test PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/hw ${CMAKE_CURRENT_SOURCE_DIR}/hw/libft4222)
   target_link_libraries(emu_hw_test PRIVATE ${GMP_LIBRARIES} ${GMPXX_LIBRARIES} Threads::Threads)
+  vdf_add_windows_clang_opts(emu_hw_test)
 
   add_executable(emu_hw_vdf_client
     ${CMAKE_CURRENT_SOURCE_DIR}/hw/hw_vdf_client.cpp
@@ -423,6 +473,7 @@ if(BUILD_HW_TOOLS)
   target_compile_definitions(emu_hw_vdf_client PRIVATE ${VDF_COMMON_DEFINITIONS})
   target_include_directories(emu_hw_vdf_client PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/hw ${CMAKE_CURRENT_SOURCE_DIR}/hw/libft4222)
   target_link_libraries(emu_hw_vdf_client PRIVATE ${GMP_LIBRARIES} ${GMPXX_LIBRARIES} Threads::Threads ${HW_SOCKET_LIBS})
+  vdf_add_windows_clang_opts(emu_hw_vdf_client)
 endif()
 
 add_executable(verifier_test

src/Makefile.vdf-client

@@ -14,12 +14,10 @@ endif
 ifeq ($(OS),Windows_NT)
 NOPIE =
 endif
-# macOS arm64 ignores -no_pie and warns; omit to avoid deprecation warnings
+# macOS linker warns that -no_pie is deprecated; omit across Darwin targets.
 ifeq ($(UNAME),Darwin)
-ifneq ($(filter $(ARCH),arm64),)
 NOPIE =
 endif
-endif
 
 CFLAGS += $(LTO_FLAGS) $(NOPIE)
 LDFLAGS += $(LTO_FLAGS) $(NOPIE) -g
@@ -57,6 +55,10 @@ endif
 ifneq ($(TSAN),)
 LDFLAGS += -fsanitize=thread
 CXXFLAGS += -g -fsanitize=thread
+ifneq (,$(findstring clang, $(shell $(CXX) --version)))
+else
+CXXFLAGS += -Wno-tsan
+endif
 endif
 
 .PHONY: all clean