remove custom allocator for GMP#230
Draft
arvidn wants to merge 1 commit into
Draft
Conversation
…s with heap corruption risks. Especially when init_gmp() is not called before everything else, and when asserting allow_integer_constructor is commented out
arvidn
force-pushed
the
no-custom-allocator
branch
from
February 4, 2025 13:00
2da32cd to
269c36f
Compare
Contributor
|
Arvid I think you are going to need to deal with _mp_d for the fast vdf software timelord stuff. It doesn't look like we use the allocator for day to day node work. |
|
'This PR has been flagged as stale due to no activity for over 60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has questionable utility and comes with heap corruption risks. Especially when init_gmp() is not called before everything else, and when asserting allow_integer_constructor is commented out