Skip to content

Fix ProveSlow tiny-iteration crash on macOS ARM (there was a regression in my regression)#318

Merged
hoffmang9 merged 1 commit into
mainfrom
fix/regression-in-my-regression-pr
Feb 20, 2026
Merged

Fix ProveSlow tiny-iteration crash on macOS ARM (there was a regression in my regression)#318
hoffmang9 merged 1 commit into
mainfrom
fix/regression-in-my-regression-pr

Conversation

@hoffmang9
Copy link
Copy Markdown
Member

@hoffmang9 hoffmang9 commented Feb 20, 2026

Summary

  • Fixes the macOS ARM optimized regression failure in ProverSlowRegressionTest by guarding tiny-iteration parameter estimation in ApproximateParameters.
  • For very small iteration counts, avoids undefined log(log(x)) behavior by clamping to a minimal valid k=1 path.
  • This follows the earlier Linux regression-linking fix already in main; there was a regression in my regression.

Test plan

  • Build regression_unit_tests locally
  • Run ./build-regression/regression_unit_tests --gtest_filter='ProverSlowRegressionTest.*'
  • Confirm both tiny-iteration tests pass

Made with Cursor


Note

Low Risk
Small, localized change that only affects parameter estimation for tiny iteration counts; main proving logic is unchanged.

Overview
Prevents ProveSlow from crashing on very small num_iterations by guarding ApproximateParameters in src/prover_slow.h against invalid log(log(x)) input.

When the intermediate value is <= 1, the function now returns early with a minimal valid setting (k = 1), avoiding undefined math during parameter estimation while leaving the normal estimation path unchanged for typical iteration counts.

Written by Cursor Bugbot for commit 4dcc304. This will update automatically on new commits. Configure here.

Prevent a macOS ARM optimized regression crash by clamping the asymptotic k estimate for very small iteration counts where log(log(x)) is undefined.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hoffmang9 hoffmang9 merged commit 8c5842f into main Feb 20, 2026
115 of 118 checks passed
@hoffmang9 hoffmang9 deleted the fix/regression-in-my-regression-pr branch February 20, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants