Videos support#15
Open
rafsanjani wants to merge 10 commits into
Open
Conversation
Contributor
|
Thanks for your contribution. |
Author
|
@APetjko The thought actually crossed my mind. I will see if I can work on it over the weekend. |
Author
|
@APetjko Self Isolation in the UK has given me some time to add support for choosing both videos and photos. You might want to check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this very useful library a lot so I decided to add the support for choosing and taking videos. I have also upgraded all dependencies to latest versions and made appropriate syntax corrections where necessary.
This can be activated by passing an optional parameter
pickerTypeto thenewInstancemethod.By default only photos can be selected.
Videos Selection
Mixture of Videos and Photos
Almost every core class has been renamed (apparently we can't keep the photo prefixes because there is video suppport now) so this enhancement causes a breaking change.
These are the classes that have changed.
SelectablePhotoSelectableMediaPhotoPickerFragmentMediaPickerFragmentPhotoPickerAdapterMediaPickerAdapterConsumers of this class only need to worry about renaming
PhotoPickerFragmenttoMediaPickerFragmentand the callback from
PhotoPickerFragment.CallbacktoMediaPickerFragment.CallbackEverything else remains the same.