Skip to content

Videos support#15

Open
rafsanjani wants to merge 10 commits into
ChiliLabs:masterfrom
rafsanjani:videos-support
Open

Videos support#15
rafsanjani wants to merge 10 commits into
ChiliLabs:masterfrom
rafsanjani:videos-support

Conversation

@rafsanjani
Copy link
Copy Markdown

@rafsanjani rafsanjani commented Mar 20, 2020

I've been using this very useful library a lot so I decided to add the support for choosing and taking videos. I have also upgraded all dependencies to latest versions and made appropriate syntax corrections where necessary.

This can be activated by passing an optional parameter pickerType to the newInstance method.
By default only photos can be selected.

Videos Selection

MediaPickerFragment.newInstance(
        multiple = true,
        allowCamera = true,
        pickerType = MediaPickerFragment.PickerType.VIDEO, //optional, default is photo
        maxSelection = 5,
        theme = R.style.ChiliPhotoPicker_Dark
    ).show(supportFragmentManager, "picker")

Mixture of Videos and Photos

MediaPickerFragment.newInstance(
            multiple = true,
            allowCamera = true,
            pickerType = MediaPickerFragment.PickerType.ANY,//optional, default is photo
            maxSelection = 5,
            theme = R.style.ChiliPhotoPicker_Dark
        ).show(supportFragmentManager, "picker")

Almost every core class has been renamed (apparently we can't keep the photo prefixes because there is video suppport now) so this enhancement causes a breaking change.
These are the classes that have changed.

Old name New Name
SelectablePhoto SelectableMedia
PhotoPickerFragment MediaPickerFragment
PhotoPickerAdapter MediaPickerAdapter

Consumers of this class only need to worry about renaming PhotoPickerFragment to MediaPickerFragment
and the callback from PhotoPickerFragment.Callback to MediaPickerFragment.Callback

Everything else remains the same.

@APetjko
Copy link
Copy Markdown
Contributor

APetjko commented Mar 20, 2020

Thanks for your contribution.
Would be nice to have option for picking both media types

@rafsanjani
Copy link
Copy Markdown
Author

@APetjko The thought actually crossed my mind. I will see if I can work on it over the weekend.

@rafsanjani
Copy link
Copy Markdown
Author

@APetjko Self Isolation in the UK has given me some time to add support for choosing both videos and photos. You might want to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants