chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/sfs (stackitcloud#1351)

Author: dependabot[bot]

go.mod

@@ -12,7 +12,7 @@ require (
 	github.com/hashicorp/terraform-plugin-go v0.30.0
 	github.com/hashicorp/terraform-plugin-log v0.10.0
 	github.com/hashicorp/terraform-plugin-testing v1.14.0
-	github.com/stackitcloud/stackit-sdk-go/core v0.24.0
+	github.com/stackitcloud/stackit-sdk-go/core v0.24.1
 	github.com/stackitcloud/stackit-sdk-go/services/alb v0.12.1
 	github.com/stackitcloud/stackit-sdk-go/services/cdn v1.13.0
 	github.com/stackitcloud/stackit-sdk-go/services/dns v0.19.1
@@ -39,7 +39,7 @@ require (
 	github.com/stackitcloud/stackit-sdk-go/services/serverupdate v1.2.6
 	github.com/stackitcloud/stackit-sdk-go/services/serviceaccount v0.12.0
 	github.com/stackitcloud/stackit-sdk-go/services/serviceenablement v1.4.1
-	github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.1
+	github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.3
 	github.com/stackitcloud/stackit-sdk-go/services/ske v1.7.0
 	github.com/stackitcloud/stackit-sdk-go/services/sqlserverflex v1.6.1
 	github.com/teambition/rrule-go v1.8.2

go.sum

@@ -153,8 +153,8 @@ github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 h1:n661drycOFuPLCN
 github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3/go.mod h1:A0bzQcvG0E7Rwjx0REVgAGH58e96+X0MeOfepqsbeW4=
 github.com/skeema/knownhosts v1.3.1 h1:X2osQ+RAjK76shCbvhHHHVl3ZlgDm8apHEHFqRjnBY8=
 github.com/skeema/knownhosts v1.3.1/go.mod h1:r7KTdC8l4uxWRyK2TpQZ/1o5HaSzh06ePQNxPwTcfiY=
-github.com/stackitcloud/stackit-sdk-go/core v0.24.0 h1:kHCcezCJ5OGSP7RRuGOxD5rF2wejpkEiRr/OdvNcuPQ=
-github.com/stackitcloud/stackit-sdk-go/core v0.24.0/go.mod h1:osMglDby4csGZ5sIfhNyYq1bS1TxIdPY88+skE/kkmI=
+github.com/stackitcloud/stackit-sdk-go/core v0.24.1 h1:IrG0XBlJivUpXC4Y6TE+6FeSxNPs1JQXsero0ivwh0o=
+github.com/stackitcloud/stackit-sdk-go/core v0.24.1/go.mod h1:osMglDby4csGZ5sIfhNyYq1bS1TxIdPY88+skE/kkmI=
 github.com/stackitcloud/stackit-sdk-go/services/alb v0.12.1 h1:RKaxAymxlyxxE0Gta3yRuQWf07LnlcX+mfGnVB96NHA=
 github.com/stackitcloud/stackit-sdk-go/services/alb v0.12.1/go.mod h1:FHkV5L9vCQha+5MX+NdMdYjQIHXcLr95+bu1FN91QOM=
 github.com/stackitcloud/stackit-sdk-go/services/authorization v0.12.0 h1:HxPgBu04j5tj6nfZ2r0l6v4VXC0/tYOGe4sA5Addra8=
@@ -171,8 +171,6 @@ github.com/stackitcloud/stackit-sdk-go/services/iaas v1.3.5 h1:W57+XRa8wTLsi5CV9
 github.com/stackitcloud/stackit-sdk-go/services/iaas v1.3.5/go.mod h1:lTWjW57eAq1bwfM6nsNinhoBr3MHFW/GaFasdAsYfDM=
 github.com/stackitcloud/stackit-sdk-go/services/kms v1.6.0 h1:WWU2LpqmazsPDgoRAVrhLzo2MiNU9dNim81z793DbBU=
 github.com/stackitcloud/stackit-sdk-go/services/kms v1.6.0/go.mod h1:FuyCm3s/Ihw+tkpVLGMXwgTtlhrijd31cUCUBWpn1p8=
-github.com/stackitcloud/stackit-sdk-go/services/loadbalancer v1.8.0 h1:DxrN85V738CRLynu6MULQHO+OXyYnkhVPgoZKULfFIs=
-github.com/stackitcloud/stackit-sdk-go/services/loadbalancer v1.8.0/go.mod h1:ClPE4TOM1FeaJiwTXvApq4gWaSgTLq6nU3PPHAIQDN4=
 github.com/stackitcloud/stackit-sdk-go/services/loadbalancer v1.11.1 h1:8hLLCP4n9w3K3dqJaKF1PnMpX4qjR8UQL3gDr80hgDI=
 github.com/stackitcloud/stackit-sdk-go/services/loadbalancer v1.11.1/go.mod h1:vqTjmecQ4+oVWzeo9tCOUZ3TrpIIzM+C0apC7cdAD0Y=
 github.com/stackitcloud/stackit-sdk-go/services/logme v0.27.1 h1:6AaWxQNtOEvIvbtyySi5KIrNzxGbKgOayUnA3fpuqns=
@@ -183,8 +181,6 @@ github.com/stackitcloud/stackit-sdk-go/services/mariadb v0.27.1 h1:YK2HxO+Nffe5B
 github.com/stackitcloud/stackit-sdk-go/services/mariadb v0.27.1/go.mod h1:/8x9gLPt1ZqcAtyVP3dwqKA9FtdHMn5pcy1TSS5iSSg=
 github.com/stackitcloud/stackit-sdk-go/services/modelserving v0.8.1 h1:qBPfWK6Xpi7eYFAZCOR4H2wkJqZMRadfAbBdJ4Qrktk=
 github.com/stackitcloud/stackit-sdk-go/services/modelserving v0.8.1/go.mod h1:b8L6f68HZce01y+eZ1o7KTRAkgpWhggpvakAEwnxnCs=
-github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.7.1 h1:8HFqfUI35Uk5QHUr3+VO21KXstzUl5zDKFrMuVOx+BI=
-github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.7.1/go.mod h1:an5vc+0PL6OBMqFl75uuQpVGyzWHBpoxc9a5p41fFA8=
 github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.7.2 h1:ymhDgp6+RXBvmi9nugaVCi3MN0q2pC62SD+Nh5nTB84=
 github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.7.2/go.mod h1:gm7KzHv788MZ2BPimrlRk3ueV8EBN4JACg/MtotGC70=
 github.com/stackitcloud/stackit-sdk-go/services/objectstorage v1.7.0 h1:UxnbsKm6PQV8Gudw/EhySaEh9q1xSaTG8mzJz1EvhnE=
@@ -213,8 +209,8 @@ github.com/stackitcloud/stackit-sdk-go/services/serviceaccount v0.12.0 h1:l1EDIl
 github.com/stackitcloud/stackit-sdk-go/services/serviceaccount v0.12.0/go.mod h1:EXq8/J7t9p8zPmdIq+atuxyAbnQwxrQT18fI+Qpv98k=
 github.com/stackitcloud/stackit-sdk-go/services/serviceenablement v1.4.1 h1:HZnZju8yqpvRIs71PEk54Jov6p+jiKIIlN+J+4tvcL0=
 github.com/stackitcloud/stackit-sdk-go/services/serviceenablement v1.4.1/go.mod h1:wBxlGcNeQPIh1aS4xYqJuN2z6haSHRwzne6drN5ROfM=
-github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.1 h1:hZSTu3gc31qpStc1Y4DUYF1xFHGBEEVBtUs6tGDLxzQ=
-github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.1/go.mod h1:I8ymS0DGUfdDUaOgSVlX0AwH/J6xTtDqEG7bip26LSE=
+github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.3 h1:LEdPJ6f9pbrft+HlIIzRcCQog58b7UKVm4ObiOH8H4o=
+github.com/stackitcloud/stackit-sdk-go/services/sfs v0.6.3/go.mod h1:qO2+XOzLy9rRTDo3IvXJd4uZsl6d1npa2cyQvaY4/Fw=
 github.com/stackitcloud/stackit-sdk-go/services/ske v1.7.0 h1:l1QjxW7sdE/6B6BZtHxbmus8XJdI9KDuXX3fwUa5fog=
 github.com/stackitcloud/stackit-sdk-go/services/ske v1.7.0/go.mod h1:1Jr+ImrmPERxbYnlTy6O2aSZYNnREf2qQyysv6YC1RY=
 github.com/stackitcloud/stackit-sdk-go/services/sqlserverflex v1.6.1 h1:aUpKF2aF8WKsHawXPFnKsRlAcaHkRg6UL0sVjuQqB74=

stackit/internal/services/objectstorage/bucket/resource.go

@@ -8,9 +8,9 @@ import (
 	"strings"
 
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/boolplanmodifier"
 	"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
 	objectstorageUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/utils"
+	boolplanmodifier "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/boolplanmodifier"
 
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-log/tflog"
@@ -36,6 +36,7 @@ var (
 	_ resource.ResourceWithModifyPlan  = &bucketResource{}
 )
 
+
 type Model struct {
 	Id                    types.String `tfsdk:"id"` // needed by TF
 	Name                  types.String `tfsdk:"name"`
@@ -160,7 +161,7 @@ func (r *bucketResource) Schema(_ context.Context, _ resource.SchemaRequest, res
 				Computed:    true,
 				Default:     booldefault.StaticBool(false),
 				PlanModifiers: []planmodifier.Bool{
-					boolplanmodifier.RequiresReplace(),
+					boolplanmodifier.RequiresReplaceIfKnown(),
 				},
 			},
 			"url_path_style": schema.StringAttribute{

stackit/internal/utils/planmodifiers/boolplanmodifier/requires_replace_if_known.go

@@ -0,0 +1,43 @@
+package boolplanmodifier
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+)
+
+type requiresReplaceIfKnownModifier struct{}
+
+// RequiresReplaceIfKnown returns a plan modifier that requires resource replacement only
+// when the prior state value is known (not null) and differs from the planned value.
+// This avoids unnecessary replacement when an attribute is introduced to the provider schema
+// after a resource was already created, where the prior state has a null value.
+func RequiresReplaceIfKnown() planmodifier.Bool {
+	return requiresReplaceIfKnownModifier{}
+}
+
+func (m requiresReplaceIfKnownModifier) Description(_ context.Context) string {
+	return "If the value of this attribute changes from a known value, Terraform will destroy and recreate the resource."
+}
+
+func (m requiresReplaceIfKnownModifier) MarkdownDescription(ctx context.Context) string {
+	return m.Description(ctx)
+}
+
+func (m requiresReplaceIfKnownModifier) PlanModifyBool(_ context.Context, req planmodifier.BoolRequest, resp *planmodifier.BoolResponse) { // nolint:gocritic // function signature required by Terraform
+	// No replace needed when creating the resource
+	if req.State.Raw.IsNull() {
+		return
+	}
+	// No replace needed when the prior state value is null (attribute newly introduced to existing resource)
+	if req.StateValue.IsNull() {
+		return
+	}
+	if req.PlanValue.IsUnknown() || req.PlanValue.IsNull() {
+		return
+	}
+	if req.StateValue.Equal(req.PlanValue) {
+		return
+	}
+	resp.RequiresReplace = true
+}

stackit/internal/utils/planmodifiers/boolplanmodifier/requires_replace_if_known_test.go

@@ -0,0 +1,96 @@
+package boolplanmodifier
+
+import (
+	"context"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/hashicorp/terraform-plugin-go/tftypes"
+)
+
+func TestRequiresReplaceIfKnown_PlanModifyBool(t *testing.T) {
+	ctx := context.Background()
+
+	// nullRawState simulates a resource that does not yet exist (creation)
+	nullRawState := tfsdk.State{
+		Raw: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{}}, nil),
+	}
+	// existingRawState simulates a resource that already exists in state
+	existingRawState := tfsdk.State{
+		Raw: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{}}, map[string]tftypes.Value{}),
+	}
+
+	tests := []struct {
+		name                    string
+		state                   tfsdk.State
+		stateValue              types.Bool
+		planValue               types.Bool
+		expectedRequiresReplace bool
+	}{
+		{
+			name:                    "resource_creation_no_replace",
+			state:                   nullRawState,
+			stateValue:              types.BoolNull(),
+			planValue:               types.BoolValue(false),
+			expectedRequiresReplace: false,
+		},
+		{
+			name:                    "null_state_value_new_attribute_no_replace",
+			state:                   existingRawState,
+			stateValue:              types.BoolNull(),
+			planValue:               types.BoolValue(false),
+			expectedRequiresReplace: false,
+		},
+		{
+			name:                    "unknown_plan_value_no_replace",
+			state:                   existingRawState,
+			stateValue:              types.BoolValue(false),
+			planValue:               types.BoolUnknown(),
+			expectedRequiresReplace: false,
+		},
+		{
+			name:                    "null_plan_value_no_replace",
+			state:                   existingRawState,
+			stateValue:              types.BoolValue(false),
+			planValue:               types.BoolNull(),
+			expectedRequiresReplace: false,
+		},
+		{
+			name:                    "state_equals_plan_no_replace",
+			state:                   existingRawState,
+			stateValue:              types.BoolValue(false),
+			planValue:               types.BoolValue(false),
+			expectedRequiresReplace: false,
+		},
+		{
+			name:                    "state_differs_from_plan_requires_replace",
+			state:                   existingRawState,
+			stateValue:              types.BoolValue(false),
+			planValue:               types.BoolValue(true),
+			expectedRequiresReplace: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			modifier := RequiresReplaceIfKnown()
+
+			req := planmodifier.BoolRequest{
+				State:      tt.state,
+				StateValue: tt.stateValue,
+				PlanValue:  tt.planValue,
+			}
+			resp := &planmodifier.BoolResponse{
+				PlanValue: tt.planValue,
+			}
+
+			modifier.PlanModifyBool(ctx, req, resp)
+
+			if resp.RequiresReplace != tt.expectedRequiresReplace {
+				t.Errorf("RequiresReplace mismatch.\nExpected: %v\nGot:      %v", tt.expectedRequiresReplace, resp.RequiresReplace)
+			}
+		})
+	}
+}