Add semantic introspection (#9533)

Author: michaelstaib

src/CookieCrumble/src/CookieCrumble.HotChocolate/Formatters/OperationResultSnapshotValueFormatter.cs

@@ -30,7 +30,7 @@ protected override void Format(IBufferWriter<byte> snapshot, OperationResult val
             writer.WriteNumber("variableIndex", value.VariableIndex.Value);
         }
 
-        if (value.Data.ValueKind is JsonValueKind.Object)
+        if (value.Data.ValueKind is JsonValueKind.Object or JsonValueKind.Null)
         {
             writer.WritePropertyName("data");
             value.Data.WriteTo(writer);

src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationTypeInterceptor.cs

@@ -274,7 +274,7 @@ private void RegisterImports()
         _schemaTypeCfg
             .GetLegacyConfiguration()
             .AddDirective(
-                new LinkDirective(version.ToUrl(), federationTypes),
+                new LinkDirective(version.ToUrl(), federationTypes.Order().ToArray()),
                 _typeInspector);
 
         foreach (var import in _imports)
@@ -287,7 +287,7 @@ private void RegisterImports()
             _schemaTypeCfg
                 .GetLegacyConfiguration()
                 .AddDirective(
-                    new LinkDirective(import.Key, import.Value),
+                    new LinkDirective(import.Key, import.Value.Order().ToArray()),
                     _typeInspector);
         }
     }

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/LinkDescriptorExtensions.cs

@@ -114,7 +114,7 @@ public static IRequestExecutorBuilder AddLink(
         builder.ConfigureSchema(
             sb =>
                 sb.AddSchemaConfiguration(
-                    d => d.Directive(new LinkDirective(url, imports?.ToHashSet()))));
+                    d => d.Directive(new LinkDirective(url, imports?.Distinct().Order().ToArray()))));
 
         return builder;
     }

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/LinkDirective.cs

@@ -19,10 +19,17 @@ public sealed class LinkDirective
     /// <param name="import">
     /// Optional list of imported elements.
     /// </param>
-    public LinkDirective(Uri url, IReadOnlySet<string>? import)
+    public LinkDirective(Uri url, IReadOnlyList<string>? import)
     {
         Url = url;
-        Import = import;
+        var imports = import?.ToArray();
+
+        if (imports is not null)
+        {
+            Array.Sort(imports, StringComparer.Ordinal);
+        }
+
+        Import = imports;
     }
 
     /// <summary>
@@ -36,5 +43,5 @@ public LinkDirective(Uri url, IReadOnlySet<string>? import)
     /// Gets optional list of imported element names.
     /// </summary>
     [GraphQLDescription(FederationResources.LinkDirective_Import_Description)]
-    public IReadOnlySet<string>? Import { get; }
+    public IReadOnlyList<string>? Import { get; }
 }

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/CertificationSchema/AnnotationBased/__snapshots__/CertificationTests.Schema_Snapshot.graphql

@@ -1,5 +1,5 @@
 schema
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@tag", "@key", "@provides", "@external", "FieldSet"]) {
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@external", "@key", "@provides", "@tag", "FieldSet"]) {
   query: Query
 }
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/CertificationSchema/AnnotationBased/__snapshots__/CertificationTests.Subgraph_SDL.snap

@@ -1,5 +1,5 @@
 schema
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@tag", "@key", "@provides", "@external", "FieldSet"]) {
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@external", "@key", "@provides", "@tag", "FieldSet"]) {
   query: Query
 }
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/CertificationSchema/CodeFirst/__snapshots__/CertificationTests.Schema_Snapshot.graphql

@@ -1,5 +1,5 @@
 schema
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@key", "@provides", "@external", "@tag", "FieldSet"]) {
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@external", "@key", "@provides", "@tag", "FieldSet"]) {
   query: Query
 }
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/CertificationSchema/CodeFirst/__snapshots__/CertificationTests.Subgraph_SDL.snap

@@ -1,5 +1,5 @@
 schema
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@key", "@provides", "@external", "@tag", "FieldSet"]) {
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@external", "@key", "@provides", "@tag", "FieldSet"]) {
   query: Query
 }
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/__snapshots__/ComposeDirectiveTests.ExportDirectiveUsingNameCodeFirst.graphql

@@ -1,6 +1,6 @@
 schema
   @composeDirective(name: "@custom")
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@key", "@tag", "FieldSet", "@composeDirective"])
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@composeDirective", "@key", "@tag", "FieldSet"])
   @link(url: "https://specs.custom.dev/custom/v1.0", import: ["@custom"]) {
   query: Query
 }

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/__snapshots__/ComposeDirectiveTests.ExportDirectiveUsingTypeCodeFirst.graphql

@@ -1,6 +1,6 @@
 schema
   @composeDirective(name: "@custom")
-  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@key", "@tag", "FieldSet", "@composeDirective"])
+  @link(url: "https://specs.apollo.dev/federation/v2.6", import: ["@composeDirective", "@key", "@tag", "FieldSet"])
   @link(url: "https://specs.custom.dev/custom/v1.0", import: ["@custom"]) {
   query: Query
 }