Optimize locking of FetchResultStore

Author: michaelstaib

docs/internal/hive-router-comparison.md

@@ -69,7 +69,7 @@ internal void Clean()
             Array.Clear(_transportContentTypes, 0, _nodeSlotCapacity);
         }
 
-        _resultStore.Clean(256, 256);
+        _resultStore.Clean();
         _executionState.Clean();
 
         RequestContext = default!;

src/HotChocolate/Fusion/src/Fusion.Execution/Execution/OperationPlanContext.Pooling.cs

@@ -23,18 +23,18 @@ namespace HotChocolate.Fusion.Execution;
 public sealed partial class OperationPlanContext : IFeatureProvider, IAsyncDisposable
 {
     private static readonly JsonOperationPlanFormatter s_planFormatter = new();
+    private readonly IFusionExecutionDiagnosticEvents _diagnosticEvents;
+    private readonly FetchResultStore _resultStore;
+    private readonly ExecutionState _executionState;
+    private readonly INodeIdParser _nodeIdParser;
+    private readonly IErrorHandler _errorHandler;
     private NodeCompletionSet?[] _nodesToComplete = [];
     private int _dependentBitsetWordCount;
     private string?[] _schemaNames = [];
     private ImmutableArray<VariableValues>[] _variableValueSets = [];
     private Uri?[] _transportUris = [];
     private string?[] _transportContentTypes = [];
     private List<IOperationPlanNode>?[] _skippedDefinitions = [];
-    private readonly IFusionExecutionDiagnosticEvents _diagnosticEvents;
-    private readonly FetchResultStore _resultStore;
-    private readonly ExecutionState _executionState;
-    private readonly INodeIdParser _nodeIdParser;
-    private readonly IErrorHandler _errorHandler;
     private bool _collectTelemetry;
     private ISourceSchemaClientScope _clientScope = default!;
     private string? _traceId;

src/HotChocolate/Fusion/src/Fusion.Execution/Execution/OperationPlanContext.cs

@@ -1,4 +1,3 @@
-using System.Buffers;
 using HotChocolate.Execution;
 using HotChocolate.Fusion.Execution.Nodes;
 using HotChocolate.Fusion.Text.Json;
@@ -8,6 +7,8 @@ namespace HotChocolate.Fusion.Execution.Results;
 
 internal sealed partial class FetchResultStore
 {
+    private const int MaxDictionaryRetainCapacity = 256;
+
     /// <summary>
     /// Initializes the <see cref="FetchResultStore"/> for a new request.
     /// </summary>
@@ -64,56 +65,30 @@ public void Reset()
     /// Cleans the store for return to the pool.
     /// Releases per-request state while retaining reusable buffers.
     /// </summary>
-    internal void Clean(int maxCollectTargetRetainLength, int maxDictionaryRetainCapacity)
+    internal void Clean()
     {
-        // drain and dispose per-request memory
         while (_memory.TryPop(out var memory))
         {
             memory.Dispose();
         }
 
-        // return path segments to global pool and reset local pool
         _pathPool.Dispose();
         _pathPool = null!;
 
-        // clear errors
         _errors?.Clear();
         _pocketedErrors?.Clear();
 
-        // reset variable writer (returns excess chunks, keeps the first)
-        _variableWriter.Clean();
-
-        // clear collect target arrays to unroot CompositeResultDocument references;
-        // if they grew too large during a burst, swap them for smaller ones.
-        TrimOrClearBuffer(ref _collectTargetA, maxCollectTargetRetainLength);
-        TrimOrClearBuffer(ref _collectTargetB, maxCollectTargetRetainLength);
-        TrimOrClearBuffer(ref _collectTargetCombined, maxCollectTargetRetainLength);
+        _builderPool.Clean();
 
-        // clear dictionaries/hashsets; drop oversized ones.
-        TrimOrClear(ref _seenPaths, maxDictionaryRetainCapacity, ReferenceEqualityComparer.Instance);
-        _variableDedupTable.Clear();
+        TrimOrClear(ref _seenPaths, MaxDictionaryRetainCapacity, ReferenceEqualityComparer.Instance);
 
-        // null out per-request references
         _result = default!;
         _valueCompletion = default!;
         _schema = default!;
         _errorHandler = default!;
         _operation = default!;
     }
 
-    private static void TrimOrClearBuffer(ref CompositeResultElement[] buffer, int maxRetainLength)
-    {
-        if (buffer.Length > maxRetainLength)
-        {
-            ArrayPool<CompositeResultElement>.Shared.Return(buffer, clearArray: true);
-            buffer = ArrayPool<CompositeResultElement>.Shared.Rent(64);
-        }
-        else
-        {
-            buffer.AsSpan().Clear();
-        }
-    }
-
     private static void TrimOrClear<TKey>(
         ref HashSet<TKey> set,
         int maxRetainCapacity,