[Analyzer] Pass type to descriptor attributes in generated code (#9752)

Author: tobias-tengler

src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs

@@ -95,7 +95,7 @@ protected void WriteInitializationBase(
             {
                 Writer.WriteIndentedLine("extension.Context,");
                 Writer.WriteIndentedLine("descriptor,");
-                Writer.WriteIndentedLine("null,");
+                Writer.WriteIndentedLine("typeof(global::{0}),", schemaFullTypeName);
 
                 var first = true;
                 foreach (var attribute in attributes)

src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/IntegrationTests.cs

@@ -75,6 +75,23 @@ public async Task Subscription_With_Public_Subscribe_Source_Is_Not_Exposed_As_Fi
             subscription.Fields.Where(f => !f.IsIntrospectionField).Select(f => f.Name).ToArray());
     }
 
+    [Fact]
+    public async Task ObjectTypeDescriptorAttribute_Should_Receive_NonNull_Type_When_Applied_To_StaticPartial_TypeExtension()
+    {
+        // arrange
+        var schema = await new ServiceCollection()
+            .AddGraphQLServer()
+            .AddIntegrationTestTypes()
+            .AddPagingArguments()
+            .BuildSchemaAsync();
+
+        // act
+        var renamedType = schema.Types.GetType<ObjectType>("renamed_DescriptorAttributeProbe");
+
+        // assert
+        Assert.NotNull(renamedType);
+    }
+
     [Fact]
     public async Task Maps_NullOrdering_From_PagingOptions_To_PagingArguments()
     {

src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/Types.cs

@@ -222,3 +222,33 @@ protected override void OnConfigure(
             });
     }
 }
+
+public class DescriptorAttributeProbe
+{
+    public string Name { get; set; } = "default";
+}
+
+[ObjectType<DescriptorAttributeProbe>]
+[PrefixTypeName("renamed")]
+public static partial class DescriptorAttributeProbeType;
+
+public sealed class PrefixTypeNameAttribute(string prefix) : ObjectTypeDescriptorAttribute
+{
+    public string Prefix { get; } = prefix;
+
+    protected override void OnConfigure(
+        IDescriptorContext context,
+        IObjectTypeDescriptor descriptor,
+        Type? type)
+    {
+        if (type is null)
+        {
+            return;
+        }
+
+        var capturedPrefix = Prefix;
+        descriptor
+            .Extend()
+            .OnBeforeCreate((_, cfg) => cfg.Name = $"{capturedPrefix}_{cfg.Name}");
+    }
+}

src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/__snapshots__/IntegrationTests.Schema_Snapshot.snap

@@ -207,6 +207,10 @@ type ProductsEdge {
   node: Product!
 }
 
+type renamed_DescriptorAttributeProbe {
+  name: String!
+}
+
 type Shape {
   key: String!
   name: String!

src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/__snapshots__/IntegrationTests.Schema_Snapshot_Without_ConnectionName_Inference.snap

@@ -164,6 +164,10 @@ type ProductEdge {
   node: Product!
 }
 
+type renamed_DescriptorAttributeProbe {
+  name: String!
+}
+
 type Shape {
   key: String!
   name: String!

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/CollectionInferenceTests.Infer_Dictionary_As_List_Of_KeyValuePair.md

@@ -67,7 +67,7 @@ namespace TestNamespace
             HotChocolate.Internal.ConfigurationHelper.ApplyConfiguration(
                 extension.Context,
                 descriptor,
-                null,
+                typeof(global::TestNamespace.Query),
                 new global::HotChocolate.Types.QueryTypeAttribute());
             configuration.ConfigurationsAreApplied = true;
 

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/LookupReturnsListTypeAnalyzerTests.Method_ArrayReturn_RaisesError.md

@@ -68,7 +68,7 @@ namespace TestNamespace
             HotChocolate.Internal.ConfigurationHelper.ApplyConfiguration(
                 extension.Context,
                 descriptor,
-                null,
+                typeof(global::TestNamespace.Query),
                 new global::HotChocolate.Types.QueryTypeAttribute());
             configuration.ConfigurationsAreApplied = true;
 

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/LookupReturnsListTypeAnalyzerTests.Method_IEnumerableReturn_RaisesError.md

@@ -68,7 +68,7 @@ namespace TestNamespace
             HotChocolate.Internal.ConfigurationHelper.ApplyConfiguration(
                 extension.Context,
                 descriptor,
-                null,
+                typeof(global::TestNamespace.Query),
                 new global::HotChocolate.Types.QueryTypeAttribute());
             configuration.ConfigurationsAreApplied = true;
 

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/LookupReturnsListTypeAnalyzerTests.Method_ListReturn_RaisesError.md

@@ -68,7 +68,7 @@ namespace TestNamespace
             HotChocolate.Internal.ConfigurationHelper.ApplyConfiguration(
                 extension.Context,
                 descriptor,
-                null,
+                typeof(global::TestNamespace.Query),
                 new global::HotChocolate.Types.QueryTypeAttribute());
             configuration.ConfigurationsAreApplied = true;
 

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/LookupReturnsListTypeAnalyzerTests.Method_NoLookupAttribute_NoError.md

@@ -67,7 +67,7 @@ namespace TestNamespace
             HotChocolate.Internal.ConfigurationHelper.ApplyConfiguration(
                 extension.Context,
                 descriptor,
-                null,
+                typeof(global::TestNamespace.Query),
                 new global::HotChocolate.Types.QueryTypeAttribute());
             configuration.ConfigurationsAreApplied = true;