Make PageCursor types shareable for ApolloFederation

[nathan-turnis]

Product

Hot Chocolate

Version

16.1.2

Link to minimal reproduction

graphql-platform/src/HotChocolate/Core/src/Types.CursorPagination.Extensions/PageCursorType.cs

Line 8 in dee2704

protected override void Configure(IObjectTypeDescriptor<PageCursor> descriptor)

Steps to reproduce

1. Set up GraphQL with .AddApolloFederation():

builder.Services.AddGraphQLServer()
.AddApolloFederation()
.AddTypes()
.AddFiltering()
.AddSorting()
.AddPagingArguments();

2. Create query with paging

[QueryType]
public static partial class EmployeeResolver
{
      [UseConnection]
      public static async Task<PageConnection<Employee>> GetEmployeeByPageTest(AppDbContext db, QueryContext<Employee> query, PagingArguments args)
      {
          return await db.Employees.With(query).ToPageAsync(args);
      }
}

3. Run multiple Subgraphs like this on an Supergraph using ApolloFederation

You get this error:

error[E029]: Encountered 2 build errors while trying to build a supergraph.

Caused by:
    INVALID_FIELD_SHARING: Non-shareable field "PageCursor.page" is resolved from multiple subgraphs: it is resolved from subgraphs "x" and "y" and defined as non-shareable in all of them
    INVALID_FIELD_SHARING: Non-shareable field "PageCursor.cursor" is resolved from multiple subgraphs: it is resolved from subgraphs "x" and "y" and defined as non-shareable in all of them

It seems like this was partially solved once before:
Issue: #7292
Pull Request: #7480

What is expected?

Supergraph compiles and runs without any additional configuration as seen here

What is actually happening?

Supergraph fails to compile due to non-shareable fields.

Relevant log output

error[E029]: Encountered 2 build errors while trying to build a supergraph.

Caused by:
    INVALID_FIELD_SHARING: Non-shareable field "PageCursor.page" is resolved from multiple subgraphs: it is resolved from subgraphs "x" and "y" and defined as non-shareable in all of them
    INVALID_FIELD_SHARING: Non-shareable field "PageCursor.cursor" is resolved from multiple subgraphs: it is resolved from subgraphs "x" and "y" and defined as non-shareable in all of them

Additional context

No response

[nathan-turnis]

Here seems to be the resulting schema that should have the @shareable directive:

"A cursor that points to a specific page."
type PageCursor {
  "The page number."
  page: Int!
  "The cursor."
  cursor: String!
}

Example of PageInfo with proper directive:

"Information about pagination in a connection."
type PageInfo {
  "Indicates whether more edges exist following the set defined by the clients arguments."
  hasNextPage: Boolean! @shareable
  "Indicates whether more edges exist prior the set defined by the clients arguments."
  hasPreviousPage: Boolean! @shareable
  "When paginating backwards, the cursor to continue."
  startCursor: String @shareable
  "When paginating forwards, the cursor to continue."
  endCursor: String @shareable
  "A list of cursors to continue paginating forwards."
  forwardCursors: [PageCursor!]! @shareable
  "A list of cursors to continue paginating backwards."
  backwardCursors: [PageCursor!]! @shareable
}