Stop cancelling in-progress main coverage runs#10006
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts GitHub Actions concurrency behavior for the “Main Branch Coverage” workflow so coverage runs on main aren’t marked red due to automatic cancellation when new commits land, while preserving serialized execution.
Changes:
- Removes
concurrency.cancel-in-progress: trueso in-progress coverage runs are no longer auto-cancelled by newer commits. - Keys the concurrency
groupby ref (main-coverage-${{ github.ref }}) to serializemainandmain-version-*independently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrency.cancel-in-progress: true, which killed an already-running coverage run whenever a newer commit landed onmain, surfacing the cancelled run as a red status in the commit list.cancel-in-progress(defaults tofalse), switching to queue mode: a running coverage job now finishes, and only superseded pending runs are cancelled. Serialization is preserved, so the latest commit's run still finishes last.main-coverage-${{ github.ref }}) somainandmain-version-*branches serialize independently rather than cancelling each other.Test plan
concurrencyblock is well-formed.cancel-in-progressunset, in-progress runs are never auto-cancelled and at most one pending run is retained per group, giving latest-wins ordering without killing active runs.