Skip to content

Stop cancelling in-progress main coverage runs#10006

Merged
glen-84 merged 1 commit into
mainfrom
gai/coverage-concurrency-queue-mode
Jun 29, 2026
Merged

Stop cancelling in-progress main coverage runs#10006
glen-84 merged 1 commit into
mainfrom
gai/coverage-concurrency-queue-mode

Conversation

@glen-84

@glen-84 glen-84 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • The Main Branch Coverage workflow used concurrency.cancel-in-progress: true, which killed an already-running coverage run whenever a newer commit landed on main, surfacing the cancelled run as a red status in the commit list.
  • Drop cancel-in-progress (defaults to false), switching to queue mode: a running coverage job now finishes, and only superseded pending runs are cancelled. Serialization is preserved, so the latest commit's run still finishes last.
  • Key the concurrency group per ref (main-coverage-${{ github.ref }}) so main and main-version-* branches serialize independently rather than cancelling each other.

Test plan

  • Confirmed the workflow YAML parses and the concurrency block is well-formed.
  • Verified against GitHub concurrency semantics: with cancel-in-progress unset, in-progress runs are never auto-cancelled and at most one pending run is retained per group, giving latest-wins ordering without killing active runs.

Copilot AI review requested due to automatic review settings June 29, 2026 15:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts GitHub Actions concurrency behavior for the “Main Branch Coverage” workflow so coverage runs on main aren’t marked red due to automatic cancellation when new commits land, while preserving serialized execution.

Changes:

  • Removes concurrency.cancel-in-progress: true so in-progress coverage runs are no longer auto-cancelled by newer commits.
  • Keys the concurrency group by ref (main-coverage-${{ github.ref }}) to serialize main and main-version-* independently.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit 47ddbe0 into main Jun 29, 2026
148 checks passed
@glen-84 glen-84 deleted the gai/coverage-concurrency-queue-mode branch June 29, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants