fix: Use Operation Interface Type instead of Runtime Type#9636
Open
cliedeman wants to merge 1 commit into
Open
fix: Use Operation Interface Type instead of Runtime Type#9636cliedeman wants to merge 1 commit into
cliedeman wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Strawberry Shake Razor component code generation so generated components inject operation services via the generated interface type (e.g., IGetBarsQuery) rather than the concrete runtime type, improving testability/mocking (Fixes #9635).
Changes:
- Emit
descriptor.InterfaceTypefor the injectedOperationproperty in Razor query components. - Emit
descriptor.InterfaceTypefor the injectedOperationproperty in Razor subscription components. - Update the Razor generator snapshot to reflect the interface-based injection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.Razor.Tests/snapshots/RazorGeneratorTests.Query_And_Mutation.snap | Updates expected generated output to inject IGetBarsQuery instead of GetBarsQuery. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/RazorSubscriptionGenerator.cs | Switches subscription component Operation injection type from runtime type to interface type. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/RazorQueryGenerator.cs | Switches query component Operation injection type from runtime type to interface type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Token(SyntaxKind.PartialKeyword)) | ||
| .AddGeneratedAttribute() | ||
| .AddMembers(CreateOperationProperty(descriptor.RuntimeType.ToString())); | ||
| .AddMembers(CreateOperationProperty(descriptor.InterfaceType.ToString())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9635