[Nitro CLI] Consume composition settings stored in Nitro#9931
Open
tobias-tengler wants to merge 5 commits into
Open
[Nitro CLI] Consume composition settings stored in Nitro#9931tobias-tengler wants to merge 5 commits into
tobias-tengler wants to merge 5 commits into
Conversation
372548e to
9d689de
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Nitro CLI/client to read Fusion composition settings stored on a stage in Nitro and apply them during fusion publish, ensuring stage-level composition configuration can override (or fall back to) archive-embedded settings.
Changes:
- Added GraphQL schema + persisted operation to fetch
Stage.compositionSettingsand exposed it viaIFusionConfigurationClient.GetStageCompositionSettingsAsync. - Updated Fusion publish flow to download stage composition settings and merge them into the effective composition settings used for composition.
- Added/updated CLI tests to validate merging semantics (null/partial stage settings) and error handling when downloading stage settings fails.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/Common/src/ChilliCream.Nitro.Client/schema.graphql | Adds schema fields/types for stage composition settings and related operations. |
| src/Nitro/Common/src/ChilliCream.Nitro.Client/persisted/operations.json | Registers a new persisted query for fetching stage composition settings. |
| src/Nitro/Common/src/ChilliCream.Nitro.Client/FusionConfiguration/StageCompositionSettings.cs | Introduces a client-side model for stage composition settings. |
| src/Nitro/Common/src/ChilliCream.Nitro.Client/FusionConfiguration/Operations/FusionStageCompositionSettingsQuery.graphql | Adds the operation to fetch compositionSettings for a stage. |
| src/Nitro/Common/src/ChilliCream.Nitro.Client/FusionConfiguration/IFusionConfigurationClient.cs | Adds the new API surface to retrieve stage composition settings. |
| src/Nitro/Common/src/ChilliCream.Nitro.Client/FusionConfiguration/FusionConfigurationClient.cs | Implements the new stage composition settings fetch and mapping. |
| src/Nitro/CommandLine/src/CommandLine/Messages.cs | Adds a CLI error message for failures when downloading stage composition settings. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs | Fetches/merges stage composition settings into the compose pipeline. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionCommandTestBase.cs | Adds test helpers for stage settings + archives with embedded composition settings. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionPublishCommandTests.cs | Adds coverage for null/partial stage settings merge behavior and failure handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9d689de to
f467045
Compare
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the branch remains at 49%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.