Stabilize Mocha saga integration tests against timing flakes#9947
Draft
glen-84 wants to merge 2 commits into
Draft
Stabilize Mocha saga integration tests against timing flakes#9947glen-84 wants to merge 2 commits into
glen-84 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes Mocha saga integration tests by replacing fixed Task.Delay waits with deterministic synchronization against persisted saga state, reducing CI timing flakes.
Changes:
- Replaced fixed delays with bounded polling that waits for specific saga persistence/deletion conditions.
- Ensured timeout tests only send
SagaTimedOutEventafter the saga instance is persisted. - Added a gated request handler to hold replies so the
AwaitingResponsepersisted state can be observed deterministically.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the branch remains at 49%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntegrationTestsrelied on fixedTask.Delaywaits before asserting on store state, which flaked under CI load: theMain Branch Coveragerun hadSaga_Should_TimeoutWithCustomResponsefail withExpected: 0, Actual: 1when 500 ms wasn't enough for the timeout to propagate.SagaTimedOutEvent, so it always targets a stored instance.Saga_Should_SupportRequestResponseuses a newGatedTriggerRequestHandlerthat holds the reply, parking the saga inAwaitingResponseso its persisted state is observable; releasing the reply then drives finalization and deletion.Test plan
dotnet test --filter-class Mocha.Sagas.Tests.IntegrationTests— 9/9 passing across multiple consecutive runs.Mocha.Sagas.Testssuite — 136 passed, 1 skipped, 0 failed.