Merge pull request #16 from Chinchill-AI/fix/systematic-scan-port-bugs

fix: resolve 10 port bugs found by systematic scan

Author: patrick-chinchill

src/chat_sdk/adapters/discord/cards.py

@@ -20,6 +20,7 @@
     SectionElement,
     TextElement,
     card_child_to_fallback_text,
+    table_element_to_ascii,
 )
 from chat_sdk.emoji import convert_emoji_placeholders
 from chat_sdk.shared.card_utils import render_gfm_table
@@ -271,9 +272,7 @@ def _child_to_fallback_text(child: CardChild) -> str | None:
     if child_type == "table":
         headers = child.get("headers", [])  # type: ignore[union-attr]
         rows = child.get("rows", [])  # type: ignore[union-attr]
-        from chat_sdk.shared.base_format_converter import table_to_ascii
-
-        return f"```\n{table_to_ascii({'type': 'table', 'children': [], 'headers': headers, 'rows': rows})}\n```"
+        return f"```\n{table_element_to_ascii(headers, rows)}\n```"
     if child_type == "divider":
         return "---"
 

src/chat_sdk/adapters/discord/format_converter.py

@@ -62,7 +62,11 @@ def to_ast(self, platform_text: str) -> Root:
         return parse_markdown(markdown)
 
     def render_postable(self, message: object) -> str:
-        """Override renderPostable to convert @mentions in plain strings."""
+        """Override renderPostable to convert @mentions in plain strings.
+
+        Extends the base implementation with Discord mention conversion
+        and dataclass-style message support.
+        """
         if isinstance(message, str):
             return self._convert_mentions_to_discord(message)
         if isinstance(message, dict):
@@ -72,7 +76,18 @@ def render_postable(self, message: object) -> str:
                 return self.from_ast(parse_markdown(message["markdown"]))
             if "ast" in message:
                 return self.from_ast(message["ast"])
-        return ""
+            if "card" in message or message.get("type") == "card":
+                return super().render_postable(message)
+            return ""
+        # Dataclass / object-style messages
+        if hasattr(message, "raw"):
+            return self._convert_mentions_to_discord(message.raw)
+        if hasattr(message, "markdown"):
+            return self.from_ast(parse_markdown(message.markdown))
+        if hasattr(message, "ast"):
+            return self.from_ast(message.ast)
+        # Fall back to base implementation for remaining cases (e.g. card objects)
+        return super().render_postable(message)
 
     def _convert_mentions_to_discord(self, text: str) -> str:
         """Convert @mentions to Discord format: @name -> <@name>."""

src/chat_sdk/adapters/google_chat/format_converter.py

@@ -112,6 +112,8 @@ def _node_to_gchat(self, node: Content) -> str:
             return f"{link_text} ({url})"
 
         if node_type == "heading":
+            # Intentional improvement over TS SDK: Google Chat has no heading
+            # syntax, so we wrap headings in bold (*...*) for visual emphasis.
             children = node.get("children", [])
             content = "".join(self._node_to_gchat(child) for child in children)
             return f"*{content}*"

src/chat_sdk/adapters/slack/format_converter.py

@@ -242,6 +242,8 @@ def _node_to_mrkdwn(self, node: Content) -> str:
             return f"<{node.get('url', '')}|{link_text}>"
 
         if node_type == "heading":
+            # Intentional improvement over TS SDK: Slack mrkdwn has no heading
+            # syntax, so we wrap headings in bold (*...*) for visual emphasis.
             content = "".join(self._node_to_mrkdwn(c) for c in children)
             return f"*{content}*"
 

src/chat_sdk/adapters/teams/cards.py

@@ -301,20 +301,9 @@ def card_to_fallback_text(card: CardElement) -> str:
     """Generate fallback text from a card element.
 
     Used when adaptive cards aren't supported.
+    Delegates to the shared implementation which handles emoji conversion
+    and renders all child types (including tables, fields, etc.) correctly.
     """
-    parts: list[str] = []
+    from chat_sdk.shared.card_utils import card_to_fallback_text as shared_card_to_fallback_text
 
-    title = card.get("title")
-    if title:
-        parts.append(f"**{_convert_emoji(title)}**")
-
-    subtitle = card.get("subtitle")
-    if subtitle:
-        parts.append(_convert_emoji(subtitle))
-
-    for child in card.get("children", []):
-        text = card_child_to_fallback_text(child)
-        if text:
-            parts.append(text)
-
-    return "\n\n".join(parts)
+    return shared_card_to_fallback_text(card, bold_format="**", line_break="\n\n", platform="teams")

src/chat_sdk/adapters/teams/format_converter.py

@@ -94,7 +94,11 @@ def to_ast(self, platform_text: str) -> Root:
         return parse_markdown(markdown)
 
     def render_postable(self, message: object) -> str:
-        """Override renderPostable to convert @mentions in plain strings."""
+        """Override renderPostable to convert @mentions in plain strings.
+
+        Extends the base implementation with Teams mention conversion
+        and dataclass-style message support.
+        """
         if isinstance(message, str):
             return self._convert_mentions_to_teams(message)
         if isinstance(message, dict):
@@ -104,7 +108,18 @@ def render_postable(self, message: object) -> str:
                 return self.from_ast(parse_markdown(message["markdown"]))
             if "ast" in message:
                 return self.from_ast(message["ast"])
-        return ""
+            if "card" in message or message.get("type") == "card":
+                return super().render_postable(message)
+            return ""
+        # Dataclass / object-style messages
+        if hasattr(message, "raw"):
+            return self._convert_mentions_to_teams(message.raw)
+        if hasattr(message, "markdown"):
+            return self.from_ast(parse_markdown(message.markdown))
+        if hasattr(message, "ast"):
+            return self.from_ast(message.ast)
+        # Fall back to base implementation for remaining cases (e.g. card objects)
+        return super().render_postable(message)
 
     def _convert_mentions_to_teams(self, text: str) -> str:
         """Convert @mentions to Teams format: @name -> <at>name</at>."""

src/chat_sdk/adapters/whatsapp/cards.py

@@ -66,7 +66,7 @@ def encode_whatsapp_callback_data(action_id: str, value: str | None = None) -> s
     payload: dict[str, str] = {"a": action_id}
     if isinstance(value, str):
         payload["v"] = value
-    return f"{CALLBACK_DATA_PREFIX}{json.dumps(payload)}"
+    return f"{CALLBACK_DATA_PREFIX}{json.dumps(payload, separators=(',', ':'))}"
 
 
 def decode_whatsapp_callback_data(data: str | None = None) -> dict[str, str | None]:

src/chat_sdk/emoji.py

@@ -65,7 +65,7 @@ def get_emoji(name: str) -> EmojiValue:
     "check": EmojiFormats(slack=["white_check_mark", "heavy_check_mark"], gchat=["✅", "✔️"]),
     "x": EmojiFormats(slack=["x", "heavy_multiplication_x"], gchat=["❌", "✖️"]),
     "question": EmojiFormats(slack="question", gchat=["❓", "?"]),
-    "exclamation": EmojiFormats(slack="exclamation", gchat=["❗", "!"]),
+    "exclamation": EmojiFormats(slack="exclamation", gchat="❗"),
     "warning": EmojiFormats(slack="warning", gchat="⚠️"),
     "stop": EmojiFormats(slack="octagonal_sign", gchat="🛑"),
     "info": EmojiFormats(slack="information_source", gchat="ℹ️"),
@@ -104,7 +104,7 @@ def get_emoji(name: str) -> EmojiValue:
     "key": EmojiFormats(slack="key", gchat="🔑"),
     "pin": EmojiFormats(slack="pushpin", gchat="📌"),
     "bell": EmojiFormats(slack="bell", gchat="🔔"),
-    "megaphone": EmojiFormats(slack="mega", gchat="📣"),
+    "megaphone": EmojiFormats(slack="mega", gchat="📢"),
     "loudspeaker": EmojiFormats(slack="loudspeaker", gchat="📢"),
     "speech_bubble": EmojiFormats(slack="speech_balloon", gchat="💬"),
     "clipboard": EmojiFormats(slack="clipboard", gchat="📋"),
@@ -193,7 +193,12 @@ def from_slack(self, slack_emoji: str) -> EmojiValue:
 
         Returns an EmojiValue for the raw emoji if no mapping exists.
         """
-        cleaned = slack_emoji.strip(":").lower()
+        cleaned = slack_emoji.lower()
+        # Strip at most one colon from each end (avoid stripping interior colons)
+        if cleaned.startswith(":"):
+            cleaned = cleaned[1:]
+        if cleaned.endswith(":"):
+            cleaned = cleaned[:-1]
         normalized = self._slack_to_normalized.get(cleaned, slack_emoji)
         return get_emoji(normalized)
 

src/chat_sdk/state/postgres.py

@@ -543,10 +543,17 @@ async def dequeue(self, thread_id: str) -> QueueEntry | None:
             return None
 
         data = json.loads(row["value"])
+        msg_data = data["message"]
+        if isinstance(msg_data, dict) and msg_data.get("_type") == "chat:Message":
+            from chat_sdk.types import Message
+
+            msg = Message.from_json(msg_data)
+        else:
+            msg = msg_data
         return QueueEntry(
             enqueued_at=data["enqueued_at"],
             expires_at=data["expires_at"],
-            message=data["message"],
+            message=msg,
         )
 
     async def queue_depth(self, thread_id: str) -> int:

src/chat_sdk/state/redis.py

@@ -308,10 +308,17 @@ async def dequeue(self, thread_id: str) -> QueueEntry | None:
             return None
 
         data = json.loads(value)
+        msg_data = data["message"]
+        if isinstance(msg_data, dict) and msg_data.get("_type") == "chat:Message":
+            from chat_sdk.types import Message
+
+            msg = Message.from_json(msg_data)
+        else:
+            msg = msg_data
         return QueueEntry(
             enqueued_at=data["enqueued_at"],
             expires_at=data["expires_at"],
-            message=data["message"],
+            message=msg,
         )
 
     async def queue_depth(self, thread_id: str) -> int: