Skip to content

Commit 4cfa184

Browse files
fix(slack): restore or-chain for user_name/full_name to match upstream
Round-2 fixup over-applied Port Rule #1. Upstream JS uses || chain intentionally — empty-string username falls through to name/user_id. The is-not-None chain preserved "" and diverged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 3f970af commit 4cfa184

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/chat_sdk/adapters/slack/adapter.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,8 +1030,11 @@ async def _handle_block_suggestion(
10301030
user_id = user_ref.get("id", "")
10311031
username = user_ref.get("username")
10321032
name = user_ref.get("name")
1033-
user_name = username if username is not None else (name if name is not None else user_id)
1034-
full_name = name if name is not None else (username if username is not None else user_id)
1033+
# Upstream uses `||` truthy-fallthrough intentionally: an empty-string
1034+
# username falls through to name, then user_id. See upstream
1035+
# packages/adapter-slack/src/index.ts lines ~1258-1260.
1036+
user_name = username or name or user_id
1037+
full_name = name or username or user_id
10351038

10361039
action_id = payload.get("action_id", "")
10371040
val = payload.get("value")

0 commit comments

Comments
 (0)