fix: address PR review comments

- Use context managers for file reads in audit_test_quality.py (3 locations)
- Remove no-op statement in test_emoji_parity.py
- Fix fallback stream final edit sending raw text instead of remended content (P1)
- Add hard cache size limits in Discord and GitHub adapters (evict oldest when full)
- TimeoutError is correct for Python >=3.11 (our minimum) — no change needed
- GChat pending subscription silent return matches TS behavior — no change needed
- Linear token refresh already has double-checked locking — no change needed

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: patrick-chinchill

scripts/audit_test_quality.py

@@ -47,7 +47,8 @@ def check_phantoms(test_files):
     """Find tests whose only statement is `assert True`."""
     issues = []
     for fpath in test_files:
-        tree = ast.parse(open(fpath).read())
+        with open(fpath, encoding="utf-8") as f:
+            tree = ast.parse(f.read())
         for node in ast.walk(tree):
             if not isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
                 continue
@@ -74,7 +75,8 @@ def check_cross_file_duplicates(test_files):
     """Find tests with identical bodies in different files."""
     bodies = collections.defaultdict(list)
     for fpath in test_files:
-        source = open(fpath).read()
+        with open(fpath, encoding="utf-8") as f:
+            source = f.read()
         tree = ast.parse(source)
         for node in ast.walk(tree):
             if not isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
@@ -98,7 +100,8 @@ def check_magicmock_for_async(test_files):
     """Find MagicMock assigned to known async method names."""
     issues = []
     for fpath in test_files:
-        source = open(fpath).read()
+        with open(fpath, encoding="utf-8") as f:
+            source = f.read()
         for i, line in enumerate(source.split("\n"), 1):
             if "MagicMock" not in line or "AsyncMock" in line:
                 continue

src/chat_sdk/adapters/discord/adapter.py

@@ -658,6 +658,11 @@ async def _handle_forwarded_reaction(
                             expired = [k for k, v in self._thread_parent_cache.items() if v.get("expires_at", 0) <= now]
                             for k in expired:
                                 del self._thread_parent_cache[k]
+                            # Hard limit: evict oldest if still over threshold
+                            if len(self._thread_parent_cache) > 1000:
+                                keys = list(self._thread_parent_cache.keys())
+                                for k in keys[: len(keys) - 1000]:
+                                    del self._thread_parent_cache[k]
                 except Exception as error:
                     self._logger.error(
                         "Failed to fetch thread parent for reaction",

src/chat_sdk/adapters/github/adapter.py

@@ -887,11 +887,15 @@ async def _get_installation_token(self, installation_id: int) -> str:
         cached token when still valid.
         """
 
-        # Purge expired entries on access
+        # Purge expired entries and enforce hard size limit
         now = time.time()
         expired_ids = [iid for iid, (_, exp) in self._installation_token_cache.items() if now >= exp]
         for iid in expired_ids:
             del self._installation_token_cache[iid]
+        if len(self._installation_token_cache) > 100:
+            keys = list(self._installation_token_cache.keys())
+            for k in keys[: len(keys) - 100]:
+                del self._installation_token_cache[k]
 
         # Check cache
         cached = self._installation_token_cache.get(installation_id)

src/chat_sdk/thread.py

@@ -626,12 +626,12 @@ async def _edit_loop() -> None:
             await self.adapter.edit_message(
                 thread_id_for_edits,
                 msg.id,
-                PostableMarkdown(markdown=accumulated),
+                PostableMarkdown(markdown=final_content),
             )
 
         sent = self._create_sent_message(
             msg.id,
-            PostableMarkdown(markdown=accumulated),
+            PostableMarkdown(markdown=final_content),
             thread_id_for_edits,
         )
         if self._message_history is not None:

tests/test_emoji_parity.py

@@ -268,8 +268,6 @@ def test_individual_emoji_parity(self, name: str):
         ts_entry = self.ts_map[name]
         assert name in DEFAULT_EMOJI_MAP, f"TS emoji {name!r} not in Python map"
 
-        DEFAULT_EMOJI_MAP[name]
-
         # Check slack[0] matches
         if ts_entry["slack"]:
             py_slack = self.resolver.to_slack(name)