Commit c72a943
committed
docs: codify divergence policy + add in-code breadcrumbs
Add a Divergence Policy section to docs/UPSTREAM_SYNC.md with:
- Criteria for when to diverge (data loss / malformed wire / hard UX
failure; cosmetic issues stay on parity).
- Required workflow (file upstream issue, diverge commit prefix, add
non-parity row, in-code breadcrumb, regression test, changelog entry).
- Review signal (sync PR title convention, budget of max 2 divergences
per sync before escalating).
Retroactively add `# Divergence from upstream — see docs/UPSTREAM_SYNC.md`
breadcrumbs at the four divergence sites introduced in this sync:
- src/chat_sdk/thread.py `_adapter_name = adapter.name` in from_json
- src/chat_sdk/channel.py same in ChannelImpl.from_json
- src/chat_sdk/adapters/google_chat/format_converter.py to_ast()
custom-link regex
- src/chat_sdk/adapters/google_chat/format_converter.py extract_plain_text()
custom-link regex
- src/chat_sdk/adapters/google_chat/format_converter.py reserved-char
fallback branch in _node_to_gchat
The placeholder-clear divergence in thread._fallback_stream already had
a full multi-line explanation; leaving that alone.
https://claude.ai/code/session_01XE1bMoQ5BjCvgi1iLGKKhG1 parent 139bb63 commit c72a943
4 files changed
Lines changed: 54 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
75 | 124 | | |
76 | 125 | | |
77 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| 70 | + | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| |||
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
| 120 | + | |
118 | 121 | | |
119 | 122 | | |
120 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
428 | 428 | | |
429 | 429 | | |
430 | 430 | | |
| 431 | + | |
431 | 432 | | |
432 | 433 | | |
433 | 434 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
779 | 779 | | |
780 | 780 | | |
781 | 781 | | |
| 782 | + | |
782 | 783 | | |
783 | 784 | | |
784 | 785 | | |
| |||
0 commit comments