Commit d125755
committed
docs(streaming): refresh native-vs-fallback wording (vercel/chat#463)
Ports the runtime-code portion of vercel/chat#463 (commit 0cc3d06) —
docstring cleanups around streaming. Upstream's #463 rewrote the
StreamingPlanOptions.updateIntervalMs comment from "fallback mode
(post + edit on adapters without native streaming)" to "Used by
post+edit streaming paths" because the interval is consulted regardless
of whether the adapter exposes its own ``stream`` method (Slack/Teams
adapters internally rate-limit edits using the same value). Same logic
applies to ThreadImpl._handle_stream's docstring and inline comment.
The other 0cc3d06 runtime fix — StreamEvent type 'step-finish' →
'finish-step' — was already correct on the Python side
(from_full_stream.py:79, thread.py:1273/1298), so nothing to do there.
Added load-bearing pins:
- TestStreamingPlanOptionsDocs::test_update_interval_ms_docstring_matches_upstream
- TestStreamingPlanOptionsDocs::test_thread_handle_stream_docstring_matches_upstream
Both fail if a future doc drift restores the stale wording.
Refs vercel/chat#463, tracking #98.
https://claude.ai/code/session_01FyMxQn2BEAzmwKS1GZczKj1 parent f0d7f1c commit d125755
4 files changed
Lines changed: 47 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
3 | 11 | | |
4 | 12 | | |
5 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
546 | | - | |
547 | | - | |
| 546 | + | |
548 | 547 | | |
549 | 548 | | |
550 | 549 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
640 | 640 | | |
641 | 641 | | |
642 | 642 | | |
643 | | - | |
| 643 | + | |
| 644 | + | |
644 | 645 | | |
645 | 646 | | |
646 | 647 | | |
| |||
674 | 675 | | |
675 | 676 | | |
676 | 677 | | |
677 | | - | |
| 678 | + | |
678 | 679 | | |
679 | 680 | | |
680 | 681 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
576 | 577 | | |
577 | 578 | | |
578 | 579 | | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
0 commit comments