Commit dc362ff
committed
test(slack): use .get() for unfurl-cache key checks to silence CodeQL
The new test_message_changed_overwrites_cached_unfurl_not_merge test
asserts ``url_literal in cache_dict`` — a dict-key membership check —
but CodeQL's incomplete-URL-substring-sanitization heuristic fires on
the bare ``in`` syntax. Switch to ``cache.get(url) is not None`` /
``is None``; same semantics, no CodeQL false positive.
https://claude.ai/code/session_01FyMxQn2BEAzmwKS1GZczKj1 parent c84fd1d commit dc362ff
1 file changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1314 | 1314 | | |
1315 | 1315 | | |
1316 | 1316 | | |
1317 | | - | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
1318 | 1322 | | |
1319 | 1323 | | |
1320 | 1324 | | |
1321 | 1325 | | |
1322 | 1326 | | |
1323 | 1327 | | |
1324 | 1328 | | |
1325 | | - | |
1326 | | - | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
1327 | 1333 | | |
1328 | 1334 | | |
1329 | 1335 | | |
| |||
0 commit comments