Skip to content

Commit fd92931

Browse files
committed
test(types): consolidate chat_sdk.types import style (codeql)
CodeQL flagged test_types.py importing chat_sdk.types both as `import chat_sdk.types as types_module` and via `from chat_sdk.types import`. Its suggested "minimal fix" (delete the aliased import) would have broken the build — `types_module` is referenced in 8 places to reach the module internals `_message_adapter_map` and `_get_message_adapter`. Correct consolidation: import those two names in the existing `from` block and drop the alias, replacing the 8 `types_module.X` references with `X`. Pure import-style change, no behavior change; test_types.py still 40 passed. https://claude.ai/code/session_01FyMxQn2BEAzmwKS1GZczKj
1 parent 44e86c1 commit fd92931

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

tests/test_types.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import weakref
88
from datetime import datetime, timezone
99

10-
import chat_sdk.types as types_module
1110
from chat_sdk.types import (
1211
Attachment,
1312
Author,
@@ -18,6 +17,8 @@
1817
MessageSubject,
1918
MessageSubjectParty,
2019
RawMessage,
20+
_get_message_adapter,
21+
_message_adapter_map,
2122
set_message_adapter,
2223
)
2324

@@ -534,19 +535,19 @@ def test_entry_removed_when_message_is_garbage_collected(self):
534535
msg = _make_message()
535536
set_message_adapter(msg, object())
536537
key = id(msg)
537-
assert key in types_module._message_adapter_map
538+
assert key in _message_adapter_map
538539
del msg
539540
gc.collect()
540-
assert key not in types_module._message_adapter_map
541+
assert key not in _message_adapter_map
541542

542543
def test_distinct_messages_get_distinct_adapters(self):
543544
m1 = _make_message()
544545
m2 = _make_message()
545546
a1, a2 = object(), object()
546547
set_message_adapter(m1, a1)
547548
set_message_adapter(m2, a2)
548-
assert types_module._get_message_adapter(m1) is a1
549-
assert types_module._get_message_adapter(m2) is a2
549+
assert _get_message_adapter(m1) is a1
550+
assert _get_message_adapter(m2) is a2
550551

551552
@staticmethod
552553
def _live_finalizer_count(message: Message) -> int:
@@ -580,9 +581,9 @@ def test_re_registration_updates_adapter_value(self):
580581
msg = _make_message()
581582
adapter_a, adapter_b = object(), object()
582583
set_message_adapter(msg, adapter_a)
583-
assert types_module._get_message_adapter(msg) is adapter_a
584+
assert _get_message_adapter(msg) is adapter_a
584585
set_message_adapter(msg, adapter_b)
585-
assert types_module._get_message_adapter(msg) is adapter_b
586+
assert _get_message_adapter(msg) is adapter_b
586587

587588
def test_re_registered_message_cleans_up_exactly_once(self):
588589
# After re-registration, GC must remove the single entry without a
@@ -591,7 +592,7 @@ def test_re_registered_message_cleans_up_exactly_once(self):
591592
set_message_adapter(msg, object())
592593
set_message_adapter(msg, object())
593594
key = id(msg)
594-
assert key in types_module._message_adapter_map
595+
assert key in _message_adapter_map
595596
del msg
596597
gc.collect()
597-
assert key not in types_module._message_adapter_map
598+
assert key not in _message_adapter_map

0 commit comments

Comments
 (0)