Commit fee58ac
committed
test(github): clear GITHUB_TOKEN env in test_throws_when_no_auth
TestGitHubAdapterConstructor.test_throws_when_no_auth expected
ValidationError on auth-less construction, but the GitHubAdapter
constructor's env-fallback path silently satisfied auth from a
GITHUB_TOKEN set by CI / dev shell — so the test failed wherever
GITHUB_TOKEN was set in the environment.
The duplicate test at line 827 in this same file already does the
env-var cleanup correctly. Apply the same pattern to line 190 so the
suite is fully green for the 0.4.27 release: pop GITHUB_TOKEN /
GITHUB_APP_ID / GITHUB_PRIVATE_KEY before the assert, restore them in
finally.1 parent 1b9cd10 commit fee58ac
1 file changed
Lines changed: 21 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
199 | 212 | | |
200 | 213 | | |
201 | 214 | | |
| |||
0 commit comments