Skip to content

chore: 0.0.1a5 release#15

Merged
patrick-chinchill merged 1 commit into
mainfrom
release-a5
Apr 7, 2026
Merged

chore: 0.0.1a5 release#15
patrick-chinchill merged 1 commit into
mainfrom
release-a5

Conversation

@patrick-chinchill
Copy link
Copy Markdown
Collaborator

Port fidelity release with 10 critical/high bug fixes.

@patrick-chinchill patrick-chinchill merged commit c393499 into main Apr 7, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the version to 0.0.1a5 and updates the changelog to reflect several critical and high-priority bug fixes across various platform adapters and core components. Review feedback identifies specific logic errors in the streaming markdown implementation regarding inline code and links, as well as a violation of the CommonMark specification in the heading parser's trailing hash stripping logic.

Comment thread CHANGELOG.md
- Teams: webhook options passed to reaction events
- Google Chat: subscription errors propagate to concurrent waiters
- Linear: fetch_thread metadata includes both key casings
- Streaming markdown `_remend` rewritten with proper delimiter tracking
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The _remend implementation in streaming_markdown.py (referenced here) has several issues that affect its fidelity:

  1. Inline Code Spans: It does not account for backticks (`). Markers like * or _ inside inline code are incorrectly counted for balancing, which leads to broken markdown when a stream contains literal markdown characters inside code spans.
  2. Code Fence Mismatch: It always appends \n\``to close unclosed code fences, even if the fence was opened with~~~`.
  3. Link Parentheses: It balances brackets [] for links but ignores the parentheses () for the URL part. A partially streamed link like [text](url will not be correctly closed.

The implementation should be updated to strip inline code content before counting markers and to track the specific fence character used.

Comment thread CHANGELOG.md

### Other improvements
- CLAUDE.md agent guidance file
- Parser: spaced thematic breaks (`* * *`) and trailing `#` stripping
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trailing # stripping logic in markdown_parser.py (line 455) is implemented using .rstrip("#"). This is overly aggressive and will incorrectly strip meaningful characters from headings that legitimately end with a hash character, such as C# or F#. According to the CommonMark specification, a closing sequence of # characters must be preceded by a space to be considered a closing sequence. The implementation should be updated to respect this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant