Address code review feedback: improve boolean comparison and null checks

Co-authored-by: theshadow76 <59869868+theshadow76@users.noreply.github.com>

Author: Copilot

pocketoptionapi_async/client.py

@@ -1036,12 +1036,13 @@ async def _on_json_data(self, data: Dict[str, Any]) -> None:
         if "requestId" in data and "asset" in data and "amount" in data:
             request_id = str(data["requestId"])
 
-            # Store mapping from server ID to request ID if server ID is present
-            if "id" in data:
+            # Store mapping from server ID to request ID if server ID is present and valid
+            if "id" in data and data["id"]:
                 server_id = str(data["id"])
-                self._server_id_to_request_id[server_id] = request_id
-                if self.enable_logging:
-                    logger.debug(f"Mapped server ID {server_id} to request ID {request_id}")
+                if server_id:  # Ensure string is not empty
+                    self._server_id_to_request_id[server_id] = request_id
+                    if self.enable_logging:
+                        logger.debug(f"Mapped server ID {server_id} to request ID {request_id}")
 
             # If this is a new order, add it to tracking
             if (
@@ -1084,7 +1085,7 @@ async def _on_json_data(self, data: Dict[str, Any]) -> None:
 
                     # If we have a mapping, use request_id to find the order
                     # Otherwise, fall back to trying server_deal_id directly
-                    lookup_id = request_id if request_id else server_deal_id
+                    lookup_id = request_id or server_deal_id
 
                     if lookup_id in self._active_orders:
                         active_order = self._active_orders[lookup_id]

tests/test_check_win.py

@@ -91,7 +91,7 @@ async def test_check_win_id_mapping():
     check_result = await client.check_win(client_request_id, max_wait_time=1.0)
 
     assert check_result is not None, "check_win should return a result"
-    assert check_result["completed"] == True, "Order should be completed"
+    assert check_result["completed"], "Order should be completed"
     assert check_result["result"] == "win", f"Result should be 'win', got {check_result['result']}"
     assert check_result["profit"] == 8.5, f"Profit should be 8.5, got {check_result['profit']}"
     print(f"   ✅ PASS: check_win returned correct result: {check_result}")