Skip to content

Commit 0da59cf

Browse files
committed
Fix mods using static vagueness
Whilst SpongePowered#415 is generating things more correctly, there are mods (such as Better End) which rely on the current behaviour
1 parent 2731d9d commit 0da59cf

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/main/java/org/spongepowered/asm/mixin/gen/AccessorGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ protected void checkModifiers() {
5858
if (!this.targetIsStatic) {
5959
throw new InvalidAccessorException(this.info, String.format("%s is invalid. Accessor method is static but the target is not.", this.info));
6060
} else {
61-
LogManager.getLogger("mixin").info("{} could be static as its target is", this.info);
61+
LogManager.getLogger("mixin").info("{} should be static as its target is", this.info);
6262
}
6363
}
6464
}
@@ -72,7 +72,7 @@ protected void checkModifiers() {
7272
*/
7373
protected final MethodNode createMethod(int maxLocals, int maxStack) {
7474
MethodNode method = this.info.getMethod();
75-
MethodNode accessor = new MethodNode(ASM.API_VERSION, (method.access & ~Opcodes.ACC_ABSTRACT) | Opcodes.ACC_SYNTHETIC | (this.targetIsStatic ? Opcodes.ACC_STATIC : 0), method.name,
75+
MethodNode accessor = new MethodNode(ASM.API_VERSION, (method.access & ~Opcodes.ACC_ABSTRACT) | Opcodes.ACC_SYNTHETIC, method.name,
7676
method.desc, null, null);
7777
accessor.visibleAnnotations = new ArrayList<AnnotationNode>();
7878
accessor.visibleAnnotations.add(this.info.getAnnotation());

0 commit comments

Comments
 (0)