Update NotificationsBuilder to use NotificationData and improve imports

Author: Choochmeque

src/lib.rs

@@ -62,15 +62,15 @@ impl<R: Runtime> NotificationsBuilder<R> {
         Self {
             app,
             plugin,
-            data: Default::default(),
+            data: NotificationData::default(),
         }
     }
 
     #[cfg(mobile)]
     fn new(handle: PluginHandle<R>) -> Self {
         Self {
             handle,
-            data: Default::default(),
+            data: NotificationData::default(),
         }
     }
 

src/macos.rs

@@ -4,17 +4,17 @@ use tauri::{
     AppHandle, Runtime,
 };
 
-use crate::models::*;
+use crate::models::{ActionType, ActiveNotification, PendingNotification};
 
 use std::{collections::HashMap, sync::Arc};
 
 pub use ffi::NotificationPlugin;
 
 /// Validation checks for macOS notifications functionality.
 ///
-/// UserNotifications requires the app to run from a signed .app bundle.
+/// `UserNotifications` requires the app to run from a signed .app bundle.
 /// During development with `tauri dev`, the binary runs
-/// directly without a bundle, causing UserNotifications calls to fail silently or crash.
+/// directly without a bundle, causing `UserNotifications` calls to fail silently or crash.
 mod validation {
     /// Ensures the app is running from a .app bundle.
     pub fn require_bundle() -> crate::Result<()> {
@@ -141,6 +141,8 @@ impl ParseFfiVoidResponse for Result<i32, ffi::FFIResult> {
 }
 
 /// Called by Swift via FFI when transaction updates occur.
+// Owned strings come straight from the Swift bridge.
+#[allow(clippy::needless_pass_by_value)]
 fn bridge_trigger(event: String, payload: String) -> Result<(), ffi::FFIResult> {
     crate::listeners::trigger(&event, payload)
         .map_err(|e| ffi::FFIResult::Err(format!("Failed to trigger event '{event}': {e}")))
@@ -165,7 +167,7 @@ impl<R: Runtime> crate::NotificationsBuilder<R> {
         self.plugin
             .show(
                 serde_json::to_string(&self.data)
-                    .map_err(|e| crate::error::PluginInvokeError::CannotSerializePayload(e))?,
+                    .map_err(crate::error::PluginInvokeError::CannotSerializePayload)?,
             )
             .await
             .parse_void()
@@ -236,7 +238,7 @@ impl<R: Runtime> Notifications<R> {
         self.plugin
             .registerActionTypes(
                 serde_json::to_string(&args)
-                    .map_err(|e| crate::error::PluginInvokeError::CannotSerializePayload(e))?,
+                    .map_err(crate::error::PluginInvokeError::CannotSerializePayload)?,
             )
             .parse_void()
     }
@@ -259,7 +261,7 @@ impl<R: Runtime> Notifications<R> {
         self.plugin
             .removeActive(
                 serde_json::to_string(&args)
-                    .map_err(|e| crate::error::PluginInvokeError::CannotSerializePayload(e))?,
+                    .map_err(crate::error::PluginInvokeError::CannotSerializePayload)?,
             )
             .parse_void()
     }
@@ -291,7 +293,7 @@ impl<R: Runtime> Notifications<R> {
         self.plugin
             .cancel(
                 serde_json::to_string(&args)
-                    .map_err(|e| crate::error::PluginInvokeError::CannotSerializePayload(e))?,
+                    .map_err(crate::error::PluginInvokeError::CannotSerializePayload)?,
             )
             .parse_void()
     }
@@ -313,7 +315,7 @@ impl<R: Runtime> Notifications<R> {
         self.plugin
             .setClickListenerActive(
                 serde_json::to_string(&args)
-                    .map_err(|e| crate::error::PluginInvokeError::CannotSerializePayload(e))?,
+                    .map_err(crate::error::PluginInvokeError::CannotSerializePayload)?,
             )
             .parse_void()
     }

src/mobile.rs

@@ -4,7 +4,11 @@ use tauri::{
     AppHandle, Runtime,
 };
 
-use crate::models::*;
+#[cfg(feature = "push-notifications")]
+use crate::models::PushNotificationResponse;
+use crate::models::{
+    ActionType, ActiveNotification, Channel, PendingNotification, PermissionResponse,
+};
 
 use std::collections::HashMap;
 
@@ -15,6 +19,8 @@ const PLUGIN_IDENTIFIER: &str = "app.tauri.notification";
 tauri::ios_plugin_binding!(init_plugin_notification);
 
 // initializes the Kotlin or Swift plugin classes
+// `PluginApi` is consumed by the framework's register helpers.
+#[allow(clippy::needless_pass_by_value)]
 pub fn init<R: Runtime, C: DeserializeOwned>(
     _app: &AppHandle<R>,
     api: PluginApi<R, C>,
@@ -157,7 +163,7 @@ impl<R: Runtime> Notifications<R> {
             .map_err(Into::into)
     }
 
-    #[allow(unused_variables)]
+    #[allow(unused_variables, clippy::needless_pass_by_value)]
     pub fn create_channel(&self, channel: Channel) -> crate::Result<()> {
         #[cfg(target_os = "android")]
         return self
@@ -170,7 +176,7 @@ impl<R: Runtime> Notifications<R> {
         )));
     }
 
-    #[allow(unused_variables)]
+    #[allow(unused_variables, clippy::needless_pass_by_value)]
     pub fn delete_channel(&self, id: impl Into<String>) -> crate::Result<()> {
         #[cfg(target_os = "android")]
         {