fix: support modern Swift release builds#269
Open
steipete wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS Swift build step in build.rs to be compatible with modern SwiftPM output layouts and to prevent swift-bridge-generated entry points from being stripped in optimized Swift builds.
Changes:
- Switch from reconstructing the SwiftPM output directory to querying it via
swift build --show-bin-path. - Preserve
swift-bridgeentry points in release builds by adding-Xswiftc -enable-testing. - Refactor the Swift invocation into a shared
swift_build_command()helper and return the resolved build output directory for linking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=========================================
Coverage 50.48% 50.48%
Complexity 65 65
=========================================
Files 31 31
Lines 6499 6499
Branches 235 235
=========================================
Hits 3281 3281
Misses 3184 3184
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-bridgeentry points in optimized Swift buildsWhy
Current Swift toolchains can place products below
Products/DebugorProducts/Release, so the hard-coded<triple>/<profile>link path fails. Optimized builds can also strip the internal@_cdeclbridge functions generated byswift-bridge; this is tracked in swift-bridge#166.Validation
cargo fmt --checkcargo check