fix: false warning in sveltekit alias (#387)

Author: Chrilleweb

.changeset/three-tools-attack.md

@@ -0,0 +1,5 @@
+---
+'dotenv-diff': patch
+---
+
+fixed false warning in sveltekit alias

packages/cli/src/core/scan/patterns.ts

@@ -4,23 +4,31 @@ type Pattern = {
   name: EnvPatternName;
   regex: RegExp;
   processor?: (match: RegExpExecArray) => string[];
+  /** When set, overrides the file-level imports list for usages from this pattern */
+  sourceModule?: string;
 };
 
 /**
  * Builds SvelteKit env patterns for an aliased import.
  * Handles: import { env as aliasName } from '$env/dynamic/private'
  * @param alias - The local alias used for the env object (e.g. "privateEnv")
+ * @param sourceModule - The specific $env module the alias was imported from
  * @returns Patterns matching aliasName.VAR and { VAR } = aliasName
  */
-export function buildSveltekitAliasPatterns(alias: string): Pattern[] {
+export function buildSveltekitAliasPatterns(
+  alias: string,
+  sourceModule: string,
+): Pattern[] {
   return [
     {
       name: 'sveltekit' as const,
       regex: new RegExp(`(?<![.\\w])${alias}\\.([A-Z_][A-Z0-9_]*)`, 'g'),
+      sourceModule,
     },
     {
       name: 'sveltekit' as const,
       regex: new RegExp(`\\{([^}]*)\\}\\s*=\\s*${alias}\\b`, 'g'),
+      sourceModule,
       processor: (match) => {
         const content = match[1];
         if (!content) return [];

packages/cli/src/core/scan/scanFile.ts

@@ -36,14 +36,20 @@ export function scanFile(
   }
 
   // Detect aliased $env imports: import { env as aliasName } from '$env/dynamic/private'
+  // Capture both the alias name (group 1) and the source module (group 2)
   const aliasImportRegex =
-    /import\s*\{\s*env\s+as\s+(\w+)\s*\}\s*from\s*['"]\$env\/(?:static|dynamic)\/(?:private|public)['"]/g;
+    /import\s*\{\s*env\s+as\s+(\w+)\s*\}\s*from\s*['"](\$env\/(?:static|dynamic)\/(?:private|public))['"]/g;
 
   const allPatterns = [...ENV_PATTERNS];
   let aliasImportMatch: RegExpExecArray | null;
 
   while ((aliasImportMatch = aliasImportRegex.exec(content)) !== null) {
-    allPatterns.push(...buildSveltekitAliasPatterns(aliasImportMatch[1]!));
+    allPatterns.push(
+      ...buildSveltekitAliasPatterns(
+        aliasImportMatch[1]!,
+        aliasImportMatch[2]!,
+      ),
+    );
   }
 
   for (const pattern of allPatterns) {
@@ -97,7 +103,7 @@ export function scanFile(
           line: lineNumber,
           column,
           pattern: pattern.name,
-          imports: envImports,
+          imports: pattern.sourceModule ? [pattern.sourceModule] : envImports,
           context: contextLine,
           isLogged,
         });

packages/cli/test/unit/core/scan/patterns.test.ts

@@ -468,27 +468,48 @@ describe('scanFile - Pattern Detection', () => {
     }
 
     it('returns two patterns for a given alias', () => {
-      const patterns = buildSveltekitAliasPatterns('privateEnv');
+      const patterns = buildSveltekitAliasPatterns(
+        'privateEnv',
+        '$env/dynamic/private',
+      );
       expect(patterns).toHaveLength(2);
       expect(patterns[0]?.regex).toBeInstanceOf(RegExp);
       expect(patterns[1]?.regex).toBeInstanceOf(RegExp);
       expect(patterns.every((p) => p.name === 'sveltekit')).toBe(true);
     });
 
+    it('sets sourceModule on both returned patterns', () => {
+      const patterns = buildSveltekitAliasPatterns(
+        'privateEnv',
+        '$env/dynamic/private',
+      );
+      expect(patterns[0]?.sourceModule).toBe('$env/dynamic/private');
+      expect(patterns[1]?.sourceModule).toBe('$env/dynamic/private');
+    });
+
     it('dot notation pattern matches alias.VAR', () => {
-      const [dotPattern] = buildSveltekitAliasPatterns('privateEnv');
+      const [dotPattern] = buildSveltekitAliasPatterns(
+        'privateEnv',
+        '$env/dynamic/private',
+      );
       expect(dotPattern!.regex.test('privateEnv.MY_SECRET')).toBe(true);
       expect(dotPattern!.regex.test('env.MY_SECRET')).toBe(false);
     });
 
     it('destructuring processor returns [] for empty content (if !content branch)', () => {
-      const [, destructurePattern] = buildSveltekitAliasPatterns('privateEnv');
+      const [, destructurePattern] = buildSveltekitAliasPatterns(
+        'privateEnv',
+        '$env/dynamic/private',
+      );
       const result = destructurePattern!.processor!(makeMatch('{}', ''));
       expect(result).toEqual([]);
     });
 
     it('destructuring processor returns [] when content is undefined', () => {
-      const [, destructurePattern] = buildSveltekitAliasPatterns('privateEnv');
+      const [, destructurePattern] = buildSveltekitAliasPatterns(
+        'privateEnv',
+        '$env/dynamic/private',
+      );
       const result = destructurePattern!.processor!(makeMatch('{}', undefined));
       expect(result).toEqual([]);
     });

packages/cli/test/unit/core/scan/scanFile.test.ts

@@ -200,6 +200,28 @@ const key = privateEnv.SUPABASE_SERVICE_ROLE_KEY;`;
     );
   });
 
+  it('sets imports to only the specific module for each aliased usage (prevents false framework warnings)', () => {
+    const content = `import { env as publicEnv } from '$env/dynamic/public';
+import { env as privateEnv } from '$env/dynamic/private';
+const url = publicEnv.PUBLIC_SUPABASE_URL;
+const key = privateEnv.SUPABASE_SERVICE_ROLE_KEY;`;
+    const usages = scanFile(
+      '/test/project/src/lib/supabase.ts',
+      content,
+      baseOpts,
+    );
+
+    const publicUsage = usages.find(
+      (u) => u.variable === 'PUBLIC_SUPABASE_URL',
+    );
+    const privateUsage = usages.find(
+      (u) => u.variable === 'SUPABASE_SERVICE_ROLE_KEY',
+    );
+
+    expect(publicUsage?.imports).toEqual(['$env/dynamic/public']);
+    expect(privateUsage?.imports).toEqual(['$env/dynamic/private']);
+  });
+
   it('detects env variables via destructuring from aliased import', () => {
     const content = `import { env as privateEnv } from '$env/dynamic/private';
 const { SECRET_KEY, API_TOKEN } = privateEnv;`;