fix: Fixed --allow-duplicates flag in default (#249)

* fix: Fixed --allow-duplicates flag in default

* ci(release): changed release flow to dispatch

Author: Chrilleweb

.github/workflows/release.yml

@@ -1,13 +1,7 @@
 name: Release
 
 on:
-  workflow_run:
-    # Trigger this workflow when the "build, test and lint" workflow completes on the main branch
-    workflows: ["build, test and lint"]
-    types:
-      - completed
-    branches:
-      - main
+  workflow_dispatch:
 
 permissions:
   contents: write

src/cli/run.ts

@@ -66,6 +66,7 @@ async function runScanMode(opts: Options): Promise<boolean> {
 
   const { exitWithError } = await scanUsage({
     cwd: opts.cwd,
+    allowDuplicates: opts.allowDuplicates,
     include: opts.includeFiles,
     exclude: opts.excludeFiles,
     ignore: opts.ignore,

src/commands/scanUsage.ts

@@ -14,6 +14,7 @@ import { printComparisonError } from '../ui/scan/printComparisonError.js';
 import { hasIgnoreComment } from '../core/security/secretDetectors.js';
 import { frameworkValidator } from '../core/frameworks/frameworkValidator.js';
 import { detectSecretsInExample } from '../core/security/exampleSecretDetector.js';
+import { DEFAULT_EXAMPLE_FILE } from '../config/constants.js';
 
 /**
  * Scans the codebase for environment variable usage and compares it with
@@ -86,7 +87,9 @@ export async function scanUsage(opts: ScanUsageOptions): Promise<ExitResult> {
     } else {
       scanResult = result.scanResult;
       comparedAgainst = result.comparedAgainst;
-      duplicatesFound = result.duplicatesFound;
+      if (result.duplicatesFound) {
+        duplicatesFound = result.duplicatesFound;
+      }
       fixApplied = result.fixApplied;
       removedDuplicates = result.removedDuplicates;
       fixedKeys = result.addedEnv;
@@ -101,7 +104,7 @@ export async function scanUsage(opts: ScanUsageOptions): Promise<ExitResult> {
         scanResult.inconsistentNamingWarnings =
           result.inconsistentNamingWarnings;
       }
-      if (result.exampleFull && result.comparedAgainst === '.env.example') {
+      if (result.exampleFull && result.comparedAgainst === DEFAULT_EXAMPLE_FILE) {
         scanResult.exampleWarnings = detectSecretsInExample(result.exampleFull);
       }
     }
@@ -128,7 +131,6 @@ export async function scanUsage(opts: ScanUsageOptions): Promise<ExitResult> {
     return {
       exitWithError:
         scanResult.missing.length > 0 ||
-        duplicatesFound ||
         hasHighSeveritySecrets ||
         hasHighSeverityExampleWarnings ||
         !!(
@@ -155,7 +157,7 @@ export async function scanUsage(opts: ScanUsageOptions): Promise<ExitResult> {
     gitignoreUpdated,
   });
 
-  return { exitWithError: result.exitWithError || duplicatesFound };
+  return { exitWithError: result.exitWithError };
 }
 
 /**

test/e2e/cli.flags.e2e.test.ts

@@ -254,6 +254,41 @@ describe('duplicate detection', () => {
     expect(res.status).toBe(0);
     expect(res.stdout).not.toContain('Duplicate keys in .env');
   });
+
+  it('will detect duplicates in scan mode', () => {
+    const cwd = tmpDir();
+    fs.writeFileSync(path.join(cwd, '.env'), 'A=1\nA=2\nC=3\n');
+        fs.writeFileSync(
+      path.join(cwd, 'app.js'),
+      `
+      const api = process.env.A;
+      const client = process.env.C;
+    `,
+    );
+
+    const res = runCli(cwd, ['--scan-usage']);
+    expect(res.status).toBe(0);
+    expect(res.stdout).toContain(
+      'Duplicate keys in .env (last occurrence wins):',
+    );
+    expect(res.stdout).toContain('- A (2 occurrences)');
+  });
+
+  it('--allow-duplicates works in scan mode', () => {
+    const cwd = tmpDir();
+    fs.writeFileSync(path.join(cwd, '.env'), 'A=1\nA=2\nC=3\n');
+    fs.writeFileSync(
+      path.join(cwd, 'app.js'),
+      `
+      const api = process.env.A;
+      const client = process.env.C;
+    `,
+    );
+
+    const res = runCli(cwd, ['--scan-usage', '--allow-duplicates']);
+    expect(res.status).toBe(0);
+    expect(res.stdout).not.toContain('Duplicate keys in .env');
+  });
   describe('--json output', () => {
     it('prints a JSON array with ok=true when files match', () => {
       const cwd = tmpDir();