fix: removed mismatch from only flag (#250)

Author: Chrilleweb

src/cli/program.ts

@@ -28,7 +28,7 @@ export function createProgram() {
     .option('--no-color', 'Disable colored output')
     .option(
       '--only <list>',
-      'Comma-separated categories to only run (missing,extra,empty,mismatch,duplicate,gitignore)',
+      'Comma-separated categories to only run (missing,extra,empty,duplicate,gitignore)',
     )
     .option('--scan-usage', 'Scan codebase for environment variable usage')
     .option('--compare', 'Compare .env and .env.example files')

src/commands/compare.ts

@@ -46,7 +46,6 @@ export async function compareMany(
     missing: 0,
     extra: 0,
     empty: 0,
-    mismatch: 0,
     duplicate: 0,
     gitignore: 0,
   };
@@ -94,8 +93,7 @@ export async function compareMany(
       missing: run('missing') ? diff.missing : [],
       extra: run('extra') ? diff.extra : [],
       empty: run('empty') ? emptyKeys : [],
-      mismatches:
-        run('mismatch') && opts.checkValues ? diff.valueMismatches : [],
+      mismatches: opts.checkValues ? diff.valueMismatches : [],
       duplicatesEnv: run('duplicate') ? dupsEnv : [],
       duplicatesEx: run('duplicate') ? dupsEx : [],
       gitignoreIssue,

src/config/constants.ts

@@ -61,7 +61,6 @@ export const ALLOWED_CATEGORIES = [
   'missing',
   'extra',
   'empty',
-  'mismatch',
   'duplicate',
   'gitignore',
 ] as const;

src/core/compare/updateTotals.ts

@@ -7,7 +7,6 @@ export interface Totals {
   missing: number;
   extra: number;
   empty: number;
-  mismatch: number;
   duplicate: number;
   gitignore: number;
 }
@@ -43,11 +42,6 @@ export function updateTotals(
     totals.empty += filtered.empty.length;
   }
 
-  if (filtered.mismatches?.length) {
-    entry.valueMismatches = filtered.mismatches;
-    totals.mismatch += filtered.mismatches.length;
-  }
-
   if (filtered.duplicatesEnv.length || filtered.duplicatesEx.length) {
     totals.duplicate +=
       filtered.duplicatesEnv.length + filtered.duplicatesEx.length;

test/e2e/cli.compare.e2e.test.ts

@@ -123,4 +123,34 @@ describe('added .env to gitignore with --compare and --fix', () => {
     expect(res.stdout).toContain('file not found');
     expect(res.stdout).toContain('Do you want to create a .env.example file from .env.local?');
   });
+
+  describe('Values mismatch checks', () => {
+    it('will report value mismatches when --check-values is set', () => {
+      const cwd = tmpDir();
+      fs.writeFileSync(path.join(cwd, '.env'), 'API_KEY=actual_value\n');
+      fs.writeFileSync(
+        path.join(cwd, '.env.example'),
+        'API_KEY=example_value\n',
+      );
+
+      const res = runCli(cwd, ['--compare', '--check-values']);
+      expect(res.status).toBe(0);
+      expect(res.stdout).toContain('Value mismatches');
+      expect(res.stdout).toContain('API_KEY');
+    });
+
+    it('will not report value mismatches when --check-values is not set', () => {
+      const cwd = tmpDir();
+      fs.writeFileSync(path.join(cwd, '.env'), 'API_KEY=actual_value\n');
+      fs.writeFileSync(
+        path.join(cwd, '.env.example'),
+        'API_KEY=example_value\n',
+      );
+
+      const res = runCli(cwd, ['--compare']);
+      expect(res.status).toBe(0);
+      expect(res.stdout).not.toContain('Value mismatches');
+      expect(res.stdout).not.toContain('API_KEY');
+    });
+  });
 });

test/unit/core/compare/updateTotals.test.ts

@@ -17,7 +17,6 @@ describe('updateTotals', () => {
       missing: 0,
       extra: 0,
       empty: 0,
-      mismatch: 0,
       duplicate: 0,
       gitignore: 0,
     };
@@ -74,23 +73,6 @@ describe('updateTotals', () => {
     expect(entry.empty).toEqual(['EMPTY1']);
   });
 
-  it('updates value mismatches', () => {
-    const filtered: Filtered = {
-      missing: [],
-      mismatches: [{ key: 'KEY1', expected: 'a', actual: 'b' }],
-      duplicatesEnv: [],
-      duplicatesEx: [],
-      gitignoreIssue: null,
-    };
-
-    updateTotals(filtered, totals, entry);
-
-    expect(totals.mismatch).toBe(1);
-    expect(entry.valueMismatches).toEqual([
-      { key: 'KEY1', expected: 'a', actual: 'b' },
-    ]);
-  });
-
   it('updates duplicates from both env and example', () => {
     const filtered: Filtered = {
       missing: [],