Skip to content

Commit be9439f

Browse files
committed
chore: minor fix
1 parent 029eb51 commit be9439f

2 files changed

Lines changed: 44 additions & 1 deletion

File tree

src/commands/scanUsage.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ export async function scanUsage(opts: ScanUsageOptions): Promise<ExitResult> {
4343
let scanResult = await scanCodebase(opts);
4444

4545
// Filter out commented usages
46-
scanResult.used = skipCommentedUsages(scanResult.used);
46+
const filteredUsages = skipCommentedUsages(scanResult.used);
47+
scanResult.used = filteredUsages;
48+
scanResult.logged = filteredUsages.filter((usage) => usage.isLogged);
4749

4850
// Measure duration
4951
const endTime = performance.now();

test/unit/commands/scanUsage.test.ts

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,47 @@ it('skips prompt when type is none and json is true', async () => {
389389
);
390390
});
391391

392+
it('removes logged warning for block-commented console env usage', async () => {
393+
vi.mocked(scanCodebase).mockResolvedValue({
394+
...baseScanResult,
395+
used: [
396+
{
397+
variable: 'TEST_KEY',
398+
file: 'src/index.ts',
399+
line: 4,
400+
column: 1,
401+
pattern: 'process.env',
402+
context: '/* console.log(process.env.TEST_KEY); */',
403+
isLogged: true,
404+
},
405+
],
406+
logged: [
407+
{
408+
variable: 'TEST_KEY',
409+
file: 'src/index.ts',
410+
line: 4,
411+
column: 1,
412+
pattern: 'process.env',
413+
context: '/* console.log(process.env.TEST_KEY); */',
414+
isLogged: true,
415+
},
416+
],
417+
});
418+
vi.mocked(determineComparisonFile).mockResolvedValue({ type: 'none' });
419+
420+
await scanUsage({ ...baseOpts, isCiMode: true });
421+
422+
expect(printScanResult).toHaveBeenCalledWith(
423+
expect.objectContaining({
424+
logged: [],
425+
used: [],
426+
}),
427+
expect.anything(),
428+
expect.anything(),
429+
expect.anything(),
430+
);
431+
});
432+
392433
it('returns exitWithError true in JSON strict mode for each warning type', async () => {
393434
const cases: Partial<ScanResult>[] = [
394435
{ duplicates: { env: [{ key: 'A', count: 2 }] } },

0 commit comments

Comments
 (0)