Skip to content

fix(security): removed http warnings #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chrilleweb merged 1 commit into from
Mar 29, 2026
Merged

fix(security): removed http warnings #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/huge-kings-make.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'dotenv-diff': patch
---

removed warning on detecting http URLs
8 changes: 4 additions & 4 deletions packages/cli/src/core/security/secretDetectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const PROVIDER_PATTERNS: RegExp[] = [
const LONG_LITERAL = /["'`]{1}([A-Za-z0-9+/_\-]{24,})["'`]{1}/g;

// Regex for detecting HTTPS URLs
const HTTPS_PATTERN = /["'`](https?:\/\/(?!localhost)[^"'`]*)["'`]/g;
const HTTPS_PATTERN = /["'`](https:\/\/(?!localhost)[^"'`]*)["'`]/g;

// List of harmless URL patterns to ignore
const HARMLESS_URLS = [
Expand Down Expand Up @@ -296,15 +296,15 @@ export function detectSecretsInSource(
const url = httpsMatch[1];
if (url && !looksHarmlessLiteral(url)) {
if (ignoreUrlsMatch(url, opts?.ignoreUrls)) continue;
const protocol = url.startsWith('https') ? 'HTTPS' : 'HTTP';

findings.push({
file,
line: lineNo,
kind: 'pattern',
message: `${protocol} URL detected – consider moving to an environment variable`,
message:
'HTTPS URL detected – consider moving to an environment variable',
snippet: line.trim().slice(0, 180),
severity: protocol === 'HTTP' ? 'medium' : 'low',
severity: 'low',
});
}
}
Expand Down
6 changes: 2 additions & 4 deletions packages/cli/test/unit/core/security/secretDetectors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,11 @@ const token = "AKIAIOSFODNN7EXAMPLE";
expect(findings[0].message).toContain('HTTPS URL detected');
});

it('should detect HTTP URLs as medium severity', () => {
it('should not detect HTTP URLs as medium severity', () => {
const source = 'const apiUrl = "http://api.realservice.com/endpoint";';
const findings = detectSecretsInSource('test.ts', source);

expect(findings).toHaveLength(1);
expect(findings[0].severity).toBe('medium');
expect(findings[0].message).toContain('HTTP URL detected');
expect(findings).toHaveLength(0);
});

it('should ignore URLs from ignoreUrls config', () => {
Expand Down