-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathAutomationProposalsController.cs
More file actions
407 lines (348 loc) · 16.5 KB
/
AutomationProposalsController.cs
File metadata and controls
407 lines (348 loc) · 16.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Taskdeck.Api.Contracts;
using Taskdeck.Api.Extensions;
using Taskdeck.Application.DTOs;
using Taskdeck.Application.Interfaces;
using Taskdeck.Application.Services;
using Taskdeck.Domain.Common;
using Taskdeck.Domain.Entities;
using Taskdeck.Domain.Exceptions;
using BoardAuthorizationService = Taskdeck.Application.Services.IAuthorizationService;
namespace Taskdeck.Api.Controllers;
/// <summary>
/// API endpoints for managing automation proposals and their lifecycle.
/// </summary>
[ApiController]
[Authorize]
[Route("api/automation/proposals")]
public class AutomationProposalsController : AuthenticatedControllerBase
{
private const int DefaultProposalListLimit = 100;
private const int MaxProposalListLimit = 500;
private const int UnscopedProposalOverfetchMultiplier = 4;
private readonly IAutomationProposalService _proposalService;
private readonly IAutomationExecutorService _executorService;
private readonly ISimilarDecisionService _similarDecisionService;
private readonly BoardAuthorizationService _authorizationService;
private readonly IProposalConflictDetector _conflictDetector;
private readonly ICardHistoryService _cardHistoryService;
private readonly ISideEffectAnalyzer _sideEffectAnalyzer;
public AutomationProposalsController(
IAutomationProposalService proposalService,
IAutomationExecutorService executorService,
ISimilarDecisionService similarDecisionService,
BoardAuthorizationService authorizationService,
IProposalConflictDetector conflictDetector,
ICardHistoryService cardHistoryService,
ISideEffectAnalyzer sideEffectAnalyzer,
IUserContext userContext) : base(userContext)
{
_proposalService = proposalService;
_executorService = executorService;
_similarDecisionService = similarDecisionService;
_authorizationService = authorizationService;
_conflictDetector = conflictDetector;
_cardHistoryService = cardHistoryService;
_sideEffectAnalyzer = sideEffectAnalyzer;
}
/// <summary>
/// Gets a list of automation proposals with optional filters.
/// </summary>
[HttpGet]
public async Task<IActionResult> GetProposals(
[FromQuery] ProposalStatus? status,
[FromQuery] Guid? boardId,
[FromQuery] Guid? userId,
[FromQuery] RiskLevel? riskLevel,
[FromQuery] int limit = 100,
CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
if (userId.HasValue && userId.Value != callerUserId)
{
return Result.Failure(ErrorCodes.Forbidden, "You can only query proposals for your own user.").ToErrorActionResult();
}
if (boardId.HasValue)
{
var permissionError = await EnsureBoardPermissionAsync(
_authorizationService,
callerUserId,
boardId.Value,
static (authorizationService, actorId, targetBoardId) => authorizationService.CanReadBoardAsync(actorId, targetBoardId),
"You do not have permission to view this board");
if (permissionError is not null)
return permissionError;
}
var requestLimit = NormalizeRequestLimit(limit);
var effectiveUserId = userId ?? (boardId.HasValue ? null : callerUserId);
var queryLimit = boardId.HasValue
? requestLimit
: Math.Clamp(requestLimit * UnscopedProposalOverfetchMultiplier, requestLimit, MaxProposalListLimit);
var filter = new ProposalFilterDto(status, boardId, effectiveUserId, riskLevel, queryLimit);
var result = await _proposalService.GetProposalsAsync(filter, cancellationToken);
if (!result.IsSuccess)
return result.ToErrorActionResult();
var proposals = result.Value.ToList();
if (!boardId.HasValue)
{
var boardScopedIds = proposals
.Where(p => p.BoardId.HasValue)
.Select(p => p.BoardId!.Value)
.Distinct()
.ToArray();
if (boardScopedIds.Length > 0)
{
var readableBoardIdsResult = await _authorizationService.GetReadableBoardIdsAsync(
callerUserId,
boardScopedIds,
cancellationToken);
if (!readableBoardIdsResult.IsSuccess)
return readableBoardIdsResult.ToErrorActionResult();
var readableBoardIds = readableBoardIdsResult.Value;
proposals = proposals
.Where(p => !p.BoardId.HasValue || readableBoardIds.Contains(p.BoardId.Value))
.ToList();
}
}
return Ok(proposals.Take(requestLimit));
}
/// <summary>
/// Gets a specific automation proposal by ID with all operations.
/// </summary>
[HttpGet("{id}")]
public async Task<IActionResult> GetProposal(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
return Ok(auth.Proposal);
}
/// <summary>
/// Creates a new automation proposal with operations.
/// </summary>
[HttpPost]
public async Task<IActionResult> CreateProposal([FromBody] CreateProposalDto dto, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var requestedByUserId, out var errorResult))
return errorResult!;
var createDto = dto with
{
RequestedByUserId = requestedByUserId
};
var result = await _proposalService.CreateProposalAsync(createDto, cancellationToken);
return result.IsSuccess
? CreatedAtAction(nameof(GetProposal), new { id = result.Value.Id }, result.Value)
: result.ToErrorActionResult();
}
/// <summary>
/// Approves a pending automation proposal.
/// </summary>
[HttpPost("{id}/approve")]
public async Task<IActionResult> ApproveProposal(
Guid id,
CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var decidedByUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, decidedByUserId, requireWriteAccess: true, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _proposalService.ApproveProposalAsync(id, decidedByUserId, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Rejects a pending automation proposal.
/// </summary>
[HttpPost("{id}/reject")]
public async Task<IActionResult> RejectProposal(
Guid id,
[FromBody] UpdateProposalStatusDto dto,
CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var decidedByUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, decidedByUserId, requireWriteAccess: true, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _proposalService.RejectProposalAsync(id, decidedByUserId, dto, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Executes an approved automation proposal through the automation executor.
/// </summary>
[HttpPost("{id}/execute")]
public async Task<IActionResult> ExecuteProposal(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: true, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
if (!Request.Headers.TryGetValue("Idempotency-Key", out var idempotencyHeader) ||
string.IsNullOrWhiteSpace(idempotencyHeader))
{
return BadRequest(new ApiErrorResponse(
ErrorCodes.ValidationError,
"Idempotency-Key header is required"));
}
var executionResult = await _executorService.ExecuteProposalAsync(id, idempotencyHeader.ToString(), cancellationToken);
if (!executionResult.IsSuccess)
return executionResult.ToErrorActionResult();
var result = await _proposalService.GetProposalByIdAsync(id, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Dismisses completed proposals so they no longer appear in the default review list.
/// Accepts an array of proposal IDs; only proposals in dismissable states
/// (Applied, Rejected, Failed, Expired, or Approved-but-expired) will be dismissed.
/// </summary>
[HttpPost("dismiss")]
public async Task<IActionResult> DismissProposals(
[FromBody] DismissProposalsRequest request,
CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
if (request.Ids is null || request.Ids.Count == 0)
{
return BadRequest(new ApiErrorResponse(
ErrorCodes.ValidationError,
"At least one proposal ID is required"));
}
if (request.Ids.Count > MaxProposalListLimit)
{
return BadRequest(new ApiErrorResponse(
ErrorCodes.ValidationError,
$"Cannot dismiss more than {MaxProposalListLimit} proposals at once"));
}
// Verify the caller owns each proposal being dismissed
foreach (var proposalId in request.Ids.Distinct())
{
var proposalResult = await _proposalService.GetProposalByIdAsync(proposalId, cancellationToken);
if (!proposalResult.IsSuccess)
return proposalResult.ToErrorActionResult();
if (proposalResult.Value.RequestedByUserId != callerUserId)
{
return Result.Failure(ErrorCodes.Forbidden, "You can only dismiss your own proposals.").ToErrorActionResult();
}
}
var result = await _proposalService.DismissProposalsAsync(request.Ids, cancellationToken);
return result.IsSuccess
? Ok(new { dismissed = result.Value })
: result.ToErrorActionResult();
}
/// <summary>
/// Gets tone-classified conflict/warning/status rows for a proposal.
/// </summary>
[HttpGet("{id}/conflicts")]
public async Task<IActionResult> GetProposalConflicts(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _conflictDetector.DetectConflictsAsync(id, callerUserId, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Gets the card history ledger for a proposal, showing all touches on affected cards.
/// </summary>
[HttpGet("{id}/history")]
public async Task<IActionResult> GetProposalHistory(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _cardHistoryService.GetCardHistoryForProposalAsync(id, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Gets the side-effect analysis for a proposal, including the 7-category breakdown
/// and reversibility posture.
/// </summary>
[HttpGet("{id}/side-effects")]
public async Task<IActionResult> GetProposalSideEffects(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _sideEffectAnalyzer.AnalyzeAsync(id, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
/// <summary>
/// Gets a diff preview for a proposal showing what changes will be made.
/// </summary>
[HttpGet("{id}/diff")]
public async Task<IActionResult> GetProposalDiff(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _proposalService.GetProposalDiffAsync(id, cancellationToken);
return result.IsSuccess ? Ok(new { diff = result.Value }) : result.ToErrorActionResult();
}
/// <summary>
/// Gets similar past decisions for a proposal, including the latest 3 decisions
/// with the same action class and an aggregate apply rate.
/// </summary>
[HttpGet("{id}/similar-past")]
public async Task<IActionResult> GetSimilarPast(Guid id, CancellationToken cancellationToken = default)
{
if (!TryGetCurrentUserId(out var callerUserId, out var errorResult))
return errorResult!;
var auth = await AuthorizeProposalAsync(id, callerUserId, requireWriteAccess: false, cancellationToken);
if (auth.ErrorResult is not null)
return auth.ErrorResult;
var result = await _similarDecisionService.GetSimilarPastAsync(id, callerUserId, cancellationToken);
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
}
private async Task<(ProposalDto? Proposal, IActionResult? ErrorResult)> AuthorizeProposalAsync(
Guid proposalId,
Guid callerUserId,
bool requireWriteAccess,
CancellationToken cancellationToken)
{
var proposalResult = await _proposalService.GetProposalByIdAsync(proposalId, cancellationToken);
if (!proposalResult.IsSuccess)
return (null, proposalResult.ToErrorActionResult());
var proposal = proposalResult.Value;
if (proposal.BoardId.HasValue)
{
var permissionError = await EnsureBoardPermissionAsync(
_authorizationService,
callerUserId,
proposal.BoardId.Value,
requireWriteAccess
? static (authorizationService, actorId, targetBoardId) => authorizationService.CanWriteBoardAsync(actorId, targetBoardId)
: static (authorizationService, actorId, targetBoardId) => authorizationService.CanReadBoardAsync(actorId, targetBoardId),
requireWriteAccess
? "You do not have permission to modify this board"
: "You do not have permission to view this board");
return permissionError is null
? (proposal, null)
: (null, permissionError);
}
if (proposal.RequestedByUserId != callerUserId)
{
return (null, Result.Failure(ErrorCodes.Forbidden, "You do not have permission to access this proposal.").ToErrorActionResult());
}
return (proposal, null);
}
private static int NormalizeRequestLimit(int requestedLimit)
{
if (requestedLimit <= 0)
return DefaultProposalListLimit;
return Math.Clamp(requestedLimit, 1, MaxProposalListLimit);
}
}