Fix testIgnore blocking audit pack; use env var gate instead

Playwright's testIgnore applies even when files are passed as explicit
CLI arguments, so the npm script always found zero tests. Replace with
TASKDECK_RUN_AUDIT env var gate on each describe block (matching the
existing stakeholder-demo and live-llm patterns). The npm script sets
the env var automatically via a cross-platform node wrapper.

Also reverts CRLF line-ending noise in playwright.config.ts and updates
MANUAL_AUDIT_PACK.md to reflect the actual CI exclusion mechanism.

Author: Chris0Jeky

docs/testing/MANUAL_AUDIT_PACK.md

@@ -64,7 +64,7 @@ Screenshots are saved as `01-home.png`, `02-inbox-with-capture.png`, etc. in the
 
 ## CI Exclusion
 
-The `manual-audit.spec.ts` file is listed in `playwright.config.ts` under `testIgnore`, so `npm run test:e2e` (the default CI command) skips it. The dedicated `npm run test:e2e:audit:headed` script explicitly targets the file, bypassing `testIgnore`.
+All tests in `manual-audit.spec.ts` are gated behind `TASKDECK_RUN_AUDIT=1`. When `npm run test:e2e` runs in CI, the env var is unset and all audit tests are skipped. The dedicated `npm run test:e2e:audit:headed` script sets the env var automatically.
 
 ## Configuration
 

frontend/taskdeck-web/package.json

@@ -23,7 +23,7 @@
     "test:ui": "vitest --ui",
     "test:coverage": "node -e \"require('fs').mkdirSync('test-results',{recursive:true})\" && vitest run --coverage --reporter=default --reporter=junit --outputFile.junit=./test-results/vitest.coverage.junit.xml",
     "test:e2e": "playwright test",
-    "test:e2e:audit:headed": "playwright test tests/e2e/manual-audit.spec.ts --headed --reporter=line",
+    "test:e2e:audit:headed": "node -e \"process.env.TASKDECK_RUN_AUDIT='1';require('child_process').execSync('npx playwright test tests/e2e/manual-audit.spec.ts --headed --reporter=line',{stdio:'inherit',env:process.env})\"",
     "test:e2e:concurrency": "playwright test tests/e2e/concurrency.spec.ts --reporter=line",
     "test:e2e:live-llm:headed": "playwright test tests/e2e/live-llm.spec.ts --headed --reporter=line",
     "test:e2e:headed": "playwright test --headed"

frontend/taskdeck-web/playwright.config.ts

@@ -1,21 +1,21 @@
 import { defineConfig } from '@playwright/test'
-import {
-  buildHttpOrigin,
-  defaultFrontendHost,
-  defaultFrontendPort,
-  parseFrontendHost,
-  resolveDefaultFrontendPort,
-} from './playwright.port-resolution'
-import { resolveDemoBackendLlmEnv, resolvePlaywrightBackendLlmEnv } from './playwright.demo-llm'
-import { resolveReuseExistingServer } from './playwright.server-reuse'
-
-const e2eDbPath = process.env.TASKDECK_E2E_DB ?? 'taskdeck.e2e.db'
-const defaultApiBaseUrl = 'http://localhost:5000/api'
-const demoBackendLlmEnv = resolveDemoBackendLlmEnv(process.env)
-const backendLlmEnv = resolvePlaywrightBackendLlmEnv(process.env)
-const reuseExistingServer = resolveReuseExistingServer(process.env, {
-  requiresFreshServer: Object.keys(demoBackendLlmEnv).length > 0,
-})
+import {
+  buildHttpOrigin,
+  defaultFrontendHost,
+  defaultFrontendPort,
+  parseFrontendHost,
+  resolveDefaultFrontendPort,
+} from './playwright.port-resolution'
+import { resolveDemoBackendLlmEnv, resolvePlaywrightBackendLlmEnv } from './playwright.demo-llm'
+import { resolveReuseExistingServer } from './playwright.server-reuse'
+
+const e2eDbPath = process.env.TASKDECK_E2E_DB ?? 'taskdeck.e2e.db'
+const defaultApiBaseUrl = 'http://localhost:5000/api'
+const demoBackendLlmEnv = resolveDemoBackendLlmEnv(process.env)
+const backendLlmEnv = resolvePlaywrightBackendLlmEnv(process.env)
+const reuseExistingServer = resolveReuseExistingServer(process.env, {
+  requiresFreshServer: Object.keys(demoBackendLlmEnv).length > 0,
+})
 
 const frontendConfig = resolveFrontendConfig()
 const frontendHost = frontendConfig.host
@@ -28,20 +28,19 @@ const backendCorsOrigins = resolveBackendCorsOrigins(
   frontendConfig.origin,
   process.env.TASKDECK_E2E_API_CORS_ORIGINS,
 )
-const backendServerEnv: Record<string, string> = {
-  ASPNETCORE_ENVIRONMENT: 'Development',
-  ConnectionStrings__DefaultConnection: `Data Source=${e2eDbPath}`,
-  ASPNETCORE_URLS: apiConfig.origin,
-  ...backendLlmEnv,
-}
+const backendServerEnv: Record<string, string> = {
+  ASPNETCORE_ENVIRONMENT: 'Development',
+  ConnectionStrings__DefaultConnection: `Data Source=${e2eDbPath}`,
+  ASPNETCORE_URLS: apiConfig.origin,
+  ...backendLlmEnv,
+}
 
 for (const [index, origin] of backendCorsOrigins.entries()) {
   backendServerEnv[`Cors__DevelopmentAllowedOrigins__${index}`] = origin
 }
 
 export default defineConfig({
   testDir: './tests/e2e',
-  testIgnore: ['**/manual-audit.spec.ts'],
   forbidOnly: !!process.env.CI,
   fullyParallel: false,
   workers: process.env.CI ? 1 : undefined,

frontend/taskdeck-web/tests/e2e/manual-audit.spec.ts

@@ -13,6 +13,9 @@
  *
  * This pack is NOT part of required CI. It is intended for local operator audits,
  * pre-release sanity checks, and visual debugging sessions.
+ *
+ * Gated behind TASKDECK_RUN_AUDIT=1. The npm script sets this automatically:
+ *   npm run test:e2e:audit:headed
  */
 
 import { expect, test } from '@playwright/test'
@@ -26,6 +29,8 @@ import {
   waitForProposalCreated,
 } from './support/captureFlow'
 
+const runAudit = parseTrueishEnv(process.env.TASKDECK_RUN_AUDIT)
+
 test.use({
   screenshot: 'on',
   trace: 'retain-on-failure',
@@ -41,6 +46,7 @@ test.beforeEach(async ({ page, request }) => {
 })
 
 test.describe('Core loop: Home -> Inbox/Capture -> Review -> Board', () => {
+  test.skip(!runAudit, 'Set TASKDECK_RUN_AUDIT=1 or use npm run test:e2e:audit:headed')
   test('full capture-triage-review-apply loop with screenshots', async ({ page, request }, testInfo) => {
     // Step 1: Home landing
     await page.goto('/workspace/home')
@@ -131,6 +137,8 @@ test.describe('Core loop: Home -> Inbox/Capture -> Review -> Board', () => {
 })
 
 test.describe('Advanced checks', () => {
+  test.skip(!runAudit, 'Set TASKDECK_RUN_AUDIT=1 or use npm run test:e2e:audit:headed')
+
   test('command palette search navigates to inbox', async ({ page }, testInfo) => {
     await page.goto('/workspace/boards')
     await expect(page.getByRole('button', { name: '+ New Board' })).toBeVisible()
@@ -218,6 +226,7 @@ test.describe('Advanced checks', () => {
 })
 
 test.describe('Live LLM provider probe', () => {
+  test.skip(!runAudit, 'Set TASKDECK_RUN_AUDIT=1 or use npm run test:e2e:audit:headed')
   test.skip(
     !parseTrueishEnv(process.env.TASKDECK_RUN_LIVE_LLM_TESTS),
     'Set TASKDECK_RUN_LIVE_LLM_TESTS=1 to run the opt-in live-provider probe.',