Skip to content

Commit be9a111

Browse files
committed
Fix adversarial review findings: remove unused import and dead code
- Remove unused 'using Taskdeck.Domain.Entities' from SideEffectDtos.cs - Remove unused hasColumnMutation variable from BuildSideEffectRows Part of #1020: paper-review-backend-gap-side-effects
1 parent ccd9d53 commit be9a111

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

backend/src/Taskdeck.Application/DTOs/SideEffectDtos.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
using Taskdeck.Domain.Entities;
2-
31
namespace Taskdeck.Application.DTOs;
42

53
public record SideEffectRowDto(

backend/src/Taskdeck.Application/Services/SideEffectAnalyzer.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ internal static IReadOnlyList<SideEffectRow> BuildSideEffectRows(
6161
bool hasActiveWebhooks)
6262
{
6363
bool hasCardMutation = operations.Any(op => CardMutatingActions.Contains(op.ActionType));
64-
bool hasColumnMutation = operations.Any(op =>
65-
string.Equals(op.TargetType, "column", StringComparison.OrdinalIgnoreCase) &&
66-
string.Equals(op.ActionType, "create_column", StringComparison.OrdinalIgnoreCase));
6764
bool hasAnyOperation = operations.Count > 0;
6865

6966
return new List<SideEffectRow>

0 commit comments

Comments
 (0)