deps: bump @stryker-mutator/core and vitest-runner to 9.6.1#842
deps: bump @stryker-mutator/core and vitest-runner to 9.6.1#842Chris0Jeky merged 1 commit intomainfrom
Conversation
Self-reviewChanges reviewed: package.json: Exactly 2 lines changed -- both package-lock.json: Lockfile updates reflect the new Stryker 9.x dependency tree. Net reduction in transitive dependencies (452 additions vs 571 deletions) -- Stryker 9.x appears to have a leaner dependency graph. Stryker config: Verification results:
Risk assessment: Low. This is a dev-only dependency (mutation testing tooling) that does not affect production builds or runtime behavior. The upgrade is straightforward with no breaking changes affecting our configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the frontend mutation-testing toolchain by upgrading Stryker JS core and its Vitest runner together to satisfy their peer dependency relationship and restore CI stability for Dependabot-driven bumps.
Changes:
- Bump
@stryker-mutator/corefrom8.7.1to9.6.1 - Bump
@stryker-mutator/vitest-runnerfrom8.7.1to9.6.1 - Refresh
package-lock.jsonto reflect the new Stryker dependency graph
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/taskdeck-web/package.json | Updates Stryker core + vitest runner devDependency versions to 9.6.1 in tandem. |
| frontend/taskdeck-web/package-lock.json | Locks the upgraded Stryker packages and their updated transitive dependencies. |
Files not reviewed (1)
- frontend/taskdeck-web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request upgrades @stryker-mutator/core and @stryker-mutator/vitest-runner from version 8.7.1 to 9.6.1, which involves extensive updates to transitive dependencies in the lockfile. The review feedback suggests pinning these packages to exact versions rather than using caret ranges to prevent potential peer dependency conflicts, as the vitest-runner requires a specific version of the core package to function correctly.
| "@stryker-mutator/core": "^9.6.1", | ||
| "@stryker-mutator/vitest-runner": "^9.6.1", |
There was a problem hiding this comment.
The @stryker-mutator/vitest-runner package version 9.6.1 has a strict peer dependency on @stryker-mutator/core at exactly version 9.6.1 (as seen in the lockfile). Using the caret (^) range in package.json allows npm to install a newer version of the core package (e.g., 9.7.0) while keeping the runner at 9.6.1, which will lead to peer dependency conflicts and installation failures. It is recommended to use exact versions for these packages to ensure they remain in sync, especially since they must be upgraded together as noted in the PR description.
| "@stryker-mutator/core": "^9.6.1", | |
| "@stryker-mutator/vitest-runner": "^9.6.1", | |
| "@stryker-mutator/core": "9.6.1", | |
| "@stryker-mutator/vitest-runner": "9.6.1", |
Summary
@stryker-mutator/corefrom 8.7.1 to 9.6.1@stryker-mutator/vitest-runnerfrom 8.7.1 to 9.6.1This combines the individual Dependabot PRs #828 (
@stryker-mutator/core) and #829 (@stryker-mutator/vitest-runner), which each failed CI because they only bumped one side of the peer dependency pair.Verification
npm ci-- clean install succeeds with both at 9.xvue-tsc --noEmit-- typecheck passesnpm run build-- full production build passesnpx vitest --run-- all 2452 unit tests pass (205 test files)stryker.config.mjs) requires no changes for 9.xnpm ls @stryker-mutator/core @stryker-mutator/vitest-runnerconfirms both at 9.6.1, dedupedTest plan