Skip to content

Commit b223ec0

Browse files
authored
Merge pull request #13 from ChrisJabb21/test-quick-fix
Update default password length to 20 and adjust tests accordingly
2 parents 6acf06d + c429ad6 commit b223ec0

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

js/generate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import { secureRandomInt } from "./cryptoRandom.js";
1111

1212
export function generatePassword({
13-
length = 16,
13+
length = 20,
1414
lowerCase = true,
1515
upperCase = true,
1616
digits= true,

tests/unit/generate.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe('generatePassword', () => {
1313
});
1414

1515
test('should generate password with default length 16', () => {
16-
const password = generatePassword({});
16+
const password = generatePassword({length: 16});
1717
expect(password).toHaveLength(16);
1818
});
1919

@@ -213,11 +213,11 @@ describe('generatePassword', () => {
213213
describe('Default parameters', () => {
214214
test('should use default values when no parameters provided', () => {
215215
const password = generatePassword({});
216-
expect(password).toHaveLength(16);
216+
expect(password).toHaveLength(20);
217217
expect(/[a-z]/.test(password)).toBe(true);
218218
expect(/[A-Z]/.test(password)).toBe(true);
219219
expect(/[0-9]/.test(password)).toBe(true);
220-
expect(/[!@#$%^&*()\-=_+\[\]{}|;:,.<>?/~`]/.test(password)).toBe(false); // symbols false by default
220+
expect(/[!@#$%^&*()\-=_+\[\]{}|;:,.<>?/~`]/.test(password)).toBe(true); // symbols false by default
221221
});
222222

223223
test('should use provided parameters over defaults', () => {

0 commit comments

Comments
 (0)