Skip to content

Commit 6e518c8

Browse files
committed
moretest fixes
1 parent d130c12 commit 6e518c8

3 files changed

Lines changed: 61 additions & 161 deletions

File tree

test/EFCore.Jet.FunctionalTests/ComplexTypesTrackingJetTest.cs

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,16 @@ public override void Can_detect_swapped_complex_objects_in_collections(bool trac
266266
{
267267
}
268268

269+
// Issue #36175: Complex types with notification change tracking are not supported
270+
public override void Can_remove_from_complex_collection_with_nested_complex_collection(bool trackFromQuery)
271+
{
272+
}
273+
274+
// Fields can't be proxied
275+
public override void Can_remove_from_complex_field_collection_with_nested_complex_collection(bool trackFromQuery)
276+
{
277+
}
278+
269279
// Issue #36175: Complex types with notification change tracking are not supported
270280
public override void Throws_when_accessing_complex_entries_using_incorrect_cardinality()
271281
{
@@ -342,6 +352,30 @@ public override void Can_write_original_values_for_properties_of_complex_propert
342352
{
343353
}
344354

355+
// Issue #36175: Complex types with notification change tracking are not supported
356+
public override Task Can_save_default_values_in_optional_complex_property_with_multiple_properties(bool async)
357+
=> Task.CompletedTask;
358+
359+
// Issue #36175: Complex types with notification change tracking are not supported
360+
public override Task Can_null_complex_property_with_default_values_and_multiple_properties(bool async)
361+
=> Task.CompletedTask;
362+
363+
// Fields can't be proxied
364+
public override Task Can_change_state_from_Deleted_with_complex_field_collection(EntityState newState, bool async)
365+
=> Task.CompletedTask;
366+
367+
// Fields can't be proxied
368+
public override Task Can_change_state_from_Deleted_with_complex_field_record_collection(EntityState newState, bool async)
369+
=> Task.CompletedTask;
370+
371+
// Issue #36175: Complex types with notification change tracking are not supported
372+
public override Task Can_change_state_from_Deleted_with_complex_collection(EntityState newState, bool async)
373+
=> Task.CompletedTask;
374+
375+
// Issue #36175: Complex types with notification change tracking are not supported
376+
public override Task Can_change_state_from_Deleted_with_complex_record_collection(EntityState newState, bool async)
377+
=> Task.CompletedTask;
378+
345379
public class JetFixture : JetFixtureBase
346380
{
347381
protected override string StoreName

test/EFCore.Jet.FunctionalTests/ComputedColumnTest.cs

Lines changed: 0 additions & 144 deletions
This file was deleted.

test/EFCore.Jet.FunctionalTests/Update/JetUpdateSqlGeneratorTest.cs

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,17 @@ public void AppendBulkInsertOperation_appends_merge_if_store_generated_columns_e
104104

105105
AssertBaseline(
106106
"""
107-
MERGE [dbo].[Ducks] USING (
108-
VALUES (@p0, @p1, @p2, 0),
109-
(@p0, @p1, @p2, 1)) AS i ([Name], [Quacks], [ConcurrencyToken], _Position) ON 1=0
110-
WHEN NOT MATCHED THEN
111-
INSERT ([Name], [Quacks], [ConcurrencyToken])
112-
VALUES (i.[Name], i.[Quacks], i.[ConcurrencyToken])
113-
OUTPUT INSERTED.[Id], INSERTED.[Computed], i._Position;
107+
INSERT INTO `Ducks` (`Name`, `Quacks`, `ConcurrencyToken`)
108+
VALUES (@p0, @p1, @p2);
109+
SELECT `Id`, `Computed`
110+
FROM `Ducks`
111+
WHERE @@ROWCOUNT = 1 AND `Id` = @@identity;
112+
113+
INSERT INTO `Ducks` (`Name`, `Quacks`, `ConcurrencyToken`)
114+
VALUES (@p0, @p1, @p2);
115+
SELECT `Id`, `Computed`
116+
FROM `Ducks`
117+
WHERE @@ROWCOUNT = 1 AND `Id` = @@identity;
114118
""",
115119
stringBuilder.ToString());
116120
Assert.Equal(ResultSetMapping.NotLastInResultSet | ResultSetMapping.IsPositionalResultMappingEnabled, grouping);
@@ -147,14 +151,17 @@ public void AppendBulkInsertOperation_appends_insert_if_store_generated_columns_
147151

148152
AssertBaseline(
149153
"""
150-
DECLARE @inserted0 TABLE ([Id] int);
151-
INSERT INTO [dbo].[Ducks] ([Id])
152-
OUTPUT INSERTED.[Id]
153-
INTO @inserted0
154-
VALUES (DEFAULT),
155-
(DEFAULT);
156-
SELECT [t].[Id], [t].[Computed] FROM [dbo].[Ducks] t
157-
INNER JOIN @inserted0 i ON ([t].[Id] = [i].[Id]);
154+
INSERT INTO `Ducks`
155+
DEFAULT VALUES;
156+
SELECT `Id`, `Computed`
157+
FROM `Ducks`
158+
WHERE @@ROWCOUNT = 1 AND `Id` = @@identity;
159+
160+
INSERT INTO `Ducks`
161+
DEFAULT VALUES;
162+
SELECT `Id`, `Computed`
163+
FROM `Ducks`
164+
WHERE @@ROWCOUNT = 1 AND `Id` = @@identity;
158165
""",
159166
stringBuilder.ToString());
160167
Assert.Equal(ResultSetMapping.NotLastInResultSet, grouping);
@@ -248,10 +255,13 @@ protected override string Identity
248255
=> throw new NotImplementedException();
249256

250257
protected override string OpenDelimiter
251-
=> "[";
258+
=> "`";
252259

253260
protected override string CloseDelimiter
254-
=> "]";
261+
=> "`";
262+
263+
protected override string Schema
264+
=> null!;
255265

256266
private void AssertBaseline(string expected, string actual)
257267
=> Assert.Equal(expected, actual.TrimEnd(), ignoreLineEndingDifferences: true);

0 commit comments

Comments
 (0)